You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2017/11/17 17:24:16 UTC
Review Request 63917: Renamed resource provider message
UpdateTotalResources to UpdateState.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63917/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.
Repository: mesos
Description
-------
This message now captures much more than just resource updates, but
instead informs users about the full resource provider state. This
change mirrors the message naming used between resource provider
manager and resource providers.
Diffs
-----
src/resource_provider/manager.cpp 6dfc42900a1e4249f37cec585f7fe50f5aa94e43
src/resource_provider/message.hpp 05879cdc01dca88440ce89beb487168c033fab37
src/slave/slave.cpp d8edc5e6bbfa265bca4d19bbaa7db3063949dbc0
src/tests/resource_provider_manager_tests.cpp ecfe2b4c0952838d6312df603f8eb2f458725175
Diff: https://reviews.apache.org/r/63917/diff/1/
Testing
-------
Thanks,
Benjamin Bannier
Re: Review Request 63917: Renamed resource provider message
UpdateTotalResources to UpdateState.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63917/
-----------------------------------------------------------
(Updated Nov. 24, 2017, 3:10 p.m.)
Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.
Changes
-------
Rebased.
Repository: mesos
Description
-------
This message now captures much more than just resource updates, but
instead informs users about the full resource provider state. This
change mirrors the message naming used between resource provider
manager and resource providers.
Diffs (updated)
-----
src/resource_provider/manager.cpp 988442a55edac93c562c2398673059384a1b2e22
src/resource_provider/message.hpp 19cf08e99b19d2d5077b3965d154cfd4554326d1
src/slave/slave.cpp f93ff7b20815c3ccb274ce6990ee66a17b6ac51c
src/tests/resource_provider_manager_tests.cpp 27fa4403651953e1ad94bbba7ef2e46344495bfa
Diff: https://reviews.apache.org/r/63917/diff/3/
Changes: https://reviews.apache.org/r/63917/diff/2-3/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 63917: Renamed resource provider message
UpdateTotalResources to UpdateState.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63917/
-----------------------------------------------------------
(Updated Nov. 21, 2017, 10:08 p.m.)
Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.
Changes
-------
Addressed Jie's comment.
Repository: mesos
Description
-------
This message now captures much more than just resource updates, but
instead informs users about the full resource provider state. This
change mirrors the message naming used between resource provider
manager and resource providers.
Diffs (updated)
-----
src/resource_provider/manager.cpp 6dfc42900a1e4249f37cec585f7fe50f5aa94e43
src/resource_provider/message.hpp 05879cdc01dca88440ce89beb487168c033fab37
src/slave/slave.cpp 6e9adc60f593faf1b0e56caeea04882f67af7080
src/tests/resource_provider_manager_tests.cpp ecfe2b4c0952838d6312df603f8eb2f458725175
Diff: https://reviews.apache.org/r/63917/diff/2/
Changes: https://reviews.apache.org/r/63917/diff/1-2/
Testing (updated)
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 63917: Renamed resource provider message
UpdateTotalResources to UpdateState.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63917/#review191421
-----------------------------------------------------------
Fix it, then Ship it!
src/resource_provider/message.hpp
Line 75 (original), 75 (patched)
<https://reviews.apache.org/r/63917/#comment269237>
Sounds like the extra `<<` in the middle is not needed.
- Jie Yu
On Nov. 17, 2017, 5:24 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63917/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2017, 5:24 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This message now captures much more than just resource updates, but
> instead informs users about the full resource provider state. This
> change mirrors the message naming used between resource provider
> manager and resource providers.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp 6dfc42900a1e4249f37cec585f7fe50f5aa94e43
> src/resource_provider/message.hpp 05879cdc01dca88440ce89beb487168c033fab37
> src/slave/slave.cpp d8edc5e6bbfa265bca4d19bbaa7db3063949dbc0
> src/tests/resource_provider_manager_tests.cpp ecfe2b4c0952838d6312df603f8eb2f458725175
>
>
> Diff: https://reviews.apache.org/r/63917/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>