You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by rd...@apache.org on 2009/08/19 20:38:24 UTC

svn commit: r805919 - /james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/JamesSpoolManager.java

Author: rdonkin
Date: Wed Aug 19 18:38:24 2009
New Revision: 805919

URL: http://svn.apache.org/viewvc?rev=805919&view=rev
Log:
Generified

Modified:
    james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/JamesSpoolManager.java

Modified: james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/JamesSpoolManager.java
URL: http://svn.apache.org/viewvc/james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/JamesSpoolManager.java?rev=805919&r1=805918&r2=805919&view=diff
==============================================================================
--- james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/JamesSpoolManager.java (original)
+++ james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/JamesSpoolManager.java Wed Aug 19 18:38:24 2009
@@ -21,8 +21,13 @@
 
 package org.apache.james.transport;
 
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+
+import javax.annotation.PostConstruct;
+
 import org.apache.avalon.framework.activity.Disposable;
-import org.apache.avalon.framework.activity.Initializable;
 import org.apache.avalon.framework.configuration.Configurable;
 import org.apache.avalon.framework.configuration.Configuration;
 import org.apache.avalon.framework.configuration.ConfigurationException;
@@ -31,17 +36,10 @@
 import org.apache.avalon.framework.service.ServiceException;
 import org.apache.avalon.framework.service.ServiceManager;
 import org.apache.avalon.framework.service.Serviceable;
-import org.apache.james.services.SpoolRepository;
 import org.apache.james.services.SpoolManager;
+import org.apache.james.services.SpoolRepository;
 import org.apache.mailet.Mail;
 
-import java.util.Collection;
-import java.util.Iterator;
-import java.util.List;
-import java.util.ArrayList;
-
-import javax.annotation.PostConstruct;
-
 /**
  * Manages the mail spool.  This class is responsible for retrieving
  * messages from the spool, directing messages to the appropriate
@@ -99,7 +97,7 @@
     /**
      * Spool threads
      */
-    private Collection spoolThreads;
+    private Collection<Thread> spoolThreads;
 
     /**
      * The mail processor 
@@ -169,7 +167,7 @@
 
         active = true;
         numActive = 0;
-        spoolThreads = new java.util.ArrayList(numThreads);
+        spoolThreads = new java.util.ArrayList<Thread>(numThreads);
         for ( int i = 0 ; i < numThreads ; i++ ) {
             Thread reader = new Thread(this, "Spool Thread #" + i);
             spoolThreads.add(reader);
@@ -277,8 +275,8 @@
     public void dispose() {
         getLogger().info("JamesSpoolManager dispose...");
         active = false; // shutdown the threads
-        for (Iterator it = spoolThreads.iterator(); it.hasNext(); ) {
-            ((Thread) it.next()).interrupt(); // interrupt any waiting accept() calls.
+        for (Thread thread: spoolThreads) {
+            thread.interrupt(); // interrupt any waiting accept() calls.
         }
 
         long stop = System.currentTimeMillis() + 60000;



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org