[GitHub] [iceberg] kbendick commented on pull request #4860: [REST Catalog Spec] Add MetadataUpdate.AssignUUID to the OpenAPI Specification

[GitBox <gi...@apache.org>]

kbendick commented on PR #4860:
URL: https://github.com/apache/iceberg/pull/4860#issuecomment-1138768406

   > LGTM !!
   > 
   > Found [RemoveSnapshotRef](https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/MetadataUpdate.java#L218-#L233) also missing, added a [PR](https://github.com/apache/iceberg/pull/4866) for the same.
   
   Good catch. That was actually the main one I was thinking of.
   
   This one is actually _not_ as important. The use case for this is actually just if people have very old table's that _don't_ already have UUID in them. I wrote the issue comment in a rush and completely misrepresented it.
   
   I am going to close this PR in favor of adding `RemoveSnapshotRef` (which is the one I was looking for). This class is mostly available in case some 3rd party needs to add UUIDs to existing tables, or make table UUIDs meet their internal standards (not something I myself use, hence the confusion).
   
   In an effort to keep the open api spec consumable, we've decided to leave this class out as it's really just in the off chance somebody has very very old tables that haven't been touched in a while but need to add UUIDs for them. Or some third party finds a use case for it to match their internal systems (of which I don't know any).
   
   So thanks for the find @singhpk234. As mentioned, RemoveSnapshotRef was actually the one I was thinking of when I made this issue.
   
   I'lll be writing a lot of documentation on the REST catalog coming up. (I also submitted for a talk on it to ApacheCon so if that gets accepted there will likely be more documentation than anybody wants on the subject). Cheers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org