You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "JackeyLee007 (via GitHub)" <gi...@apache.org> on 2024/12/13 12:42:17 UTC
[PR] [flink] kafka_sync_database supports different prefix and suffix for different db [paimon]
JackeyLee007 opened a new pull request, #4704:
URL: https://github.com/apache/paimon/pull/4704
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #4703
<!-- What is the purpose of the change -->
With kafka_sync_database, user can specify different prefix and suffix for different db.
### Tests
<!-- List UT and IT cases to verify this change -->
org.apache.paimon.flink.action.cdc.TableNameConverterTest#testConvertTableNameByDBPrefix_Suffix
### API and Format
<!-- Does this change affect API or storage format -->
No
### Documentation
<!-- Does this change introduce a new feature -->
Yes and provided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] kafka_sync_database supports different prefix and suffix for different db [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #4704:
URL: https://github.com/apache/paimon/pull/4704#issuecomment-2543458151
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] kafka_sync_database supports different prefix and suffix for different db [paimon]
Posted by "JackeyLee007 (via GitHub)" <gi...@apache.org>.
JackeyLee007 commented on code in PR #4704:
URL: https://github.com/apache/paimon/pull/4704#discussion_r1884760111
##########
pom.xml:
##########
@@ -529,6 +529,7 @@ under the License.
<exclude>release/**</exclude>
<!-- antlr grammar files -->
<exclude>paimon-common/src/main/antlr4/**</exclude>
+ <exclude>paimon-core/src/test/resources/compatibility/**</exclude>
Review Comment:
If not, the rat-plugin always report license warning when building locally as the following:
[WARNING] Files with unapproved licenses:
paimon-core/src/test/resources/compatibility/datasplit-v1
paimon-core/src/test/resources/compatibility/datasplit-v2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] kafka_sync_database supports different prefix and suffix for different db [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #4704:
URL: https://github.com/apache/paimon/pull/4704#discussion_r1883993990
##########
pom.xml:
##########
@@ -529,6 +529,7 @@ under the License.
<exclude>release/**</exclude>
<!-- antlr grammar files -->
<exclude>paimon-common/src/main/antlr4/**</exclude>
+ <exclude>paimon-core/src/test/resources/compatibility/**</exclude>
Review Comment:
why add this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] kafka_sync_database supports different prefix and suffix for different db [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #4704:
URL: https://github.com/apache/paimon/pull/4704#discussion_r1883993232
##########
paimon-flink/paimon-flink-cdc/src/main/java/org/apache/paimon/flink/action/cdc/mysql/MySqlSyncDatabaseAction.java:
##########
@@ -143,7 +143,8 @@ protected void beforeBuildingSourceSink() throws Exception {
for (JdbcTableInfo tableInfo : jdbcTableInfos) {
Identifier identifier =
Identifier.create(
- database, tableNameConverter.convert(tableInfo.toPaimonTableName()));
+ database,
+ tableNameConverter.convert("", tableInfo.toPaimonTableName()));
Review Comment:
database?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] kafka_sync_database supports different prefix and suffix for different db [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #4704:
URL: https://github.com/apache/paimon/pull/4704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] kafka_sync_database supports different prefix and suffix for different db [paimon]
Posted by "JackeyLee007 (via GitHub)" <gi...@apache.org>.
JackeyLee007 commented on code in PR #4704:
URL: https://github.com/apache/paimon/pull/4704#discussion_r1884763558
##########
paimon-flink/paimon-flink-cdc/src/main/java/org/apache/paimon/flink/action/cdc/mysql/MySqlSyncDatabaseAction.java:
##########
@@ -143,7 +143,8 @@ protected void beforeBuildingSourceSink() throws Exception {
for (JdbcTableInfo tableInfo : jdbcTableInfos) {
Identifier identifier =
Identifier.create(
- database, tableNameConverter.convert(tableInfo.toPaimonTableName()));
+ database,
+ tableNameConverter.convert("", tableInfo.toPaimonTableName()));
Review Comment:
Actually, I changed nothing but supply default value for the first argument of the "convert" method.
In this context, the prefix and suffix are not specified by database, so it's ok to provide an empty string as the argument value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] kafka_sync_database supports different prefix and suffix for different db [paimon]
Posted by "JackeyLee007 (via GitHub)" <gi...@apache.org>.
JackeyLee007 commented on code in PR #4704:
URL: https://github.com/apache/paimon/pull/4704#discussion_r1884763558
##########
paimon-flink/paimon-flink-cdc/src/main/java/org/apache/paimon/flink/action/cdc/mysql/MySqlSyncDatabaseAction.java:
##########
@@ -143,7 +143,8 @@ protected void beforeBuildingSourceSink() throws Exception {
for (JdbcTableInfo tableInfo : jdbcTableInfos) {
Identifier identifier =
Identifier.create(
- database, tableNameConverter.convert(tableInfo.toPaimonTableName()));
+ database,
+ tableNameConverter.convert("", tableInfo.toPaimonTableName()));
Review Comment:
Actually, I changed nothing but supply default value for the first argument for the "convert" method.
For this context, the prefix and suffix are not specified by database, so it's ok to provide an empty string as the argument value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org