You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by sf...@apache.org on 2010/11/18 21:20:12 UTC
svn commit: r1036605 - /httpd/httpd/trunk/modules/proxy/proxy_util.c
Author: sf
Date: Thu Nov 18 20:20:12 2010
New Revision: 1036605
URL: http://svn.apache.org/viewvc?rev=1036605&view=rev
Log:
Fix 'comparison is always false due to limited range of data type'.
One-bit flags should really be unsigned
Modified:
httpd/httpd/trunk/modules/proxy/proxy_util.c
Modified: httpd/httpd/trunk/modules/proxy/proxy_util.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/proxy_util.c?rev=1036605&r1=1036604&r2=1036605&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/proxy/proxy_util.c (original)
+++ httpd/httpd/trunk/modules/proxy/proxy_util.c Thu Nov 18 20:20:12 2010
@@ -2538,7 +2538,7 @@ PROXY_DECLARE(int) ap_proxy_connect_back
"proxy: %s: fam %d socket created to connect to %s",
proxy_function, backend_addr->family, worker->hostname);
- if (conf->source_address_set == 1) {
+ if (conf->source_address_set) {
local_addr = apr_pcalloc(conn->pool, sizeof(apr_sockaddr_t));
memcpy(local_addr, conf->source_address, sizeof(apr_sockaddr_t));
local_addr->pool = conn->pool;