You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by gauravaradhye <gi...@git.apache.org> on 2015/03/09 09:57:09 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8299: Adding additional test c...
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/102
CLOUDSTACK-8299: Adding additional test case to test ingress rules with two security groups together
This is in addition to pull request at https://github.com/apache/cloudstack/pull/95.
Testing the same functionality but with adding new security group.
This test cases tests that when two different ingress rules are present in two different security groups in the same account, then the rules are respected and the functionality works properly.
Log:
Test ingress rules for specific IP set ... SKIP: skip
Test ingress rules for specific IP set and non default security group ... === TestName:
test_ingress_rules_specific_IP_set_non_def_sec_group | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 2 tests in 649.628s
OK (SKIP=1)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gauravaradhye/cloudstack master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/102.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #102
----
commit ceaeea0150d4977c297f377672ea2c930caee2b9
Author: Gaurav Aradhye <ga...@clogeny.com>
Date: 2015-03-09T08:51:44Z
CLOUDSTACK-8299: Adding additional test case to test ingress rules with two security groups together
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8299: Adding additional test c...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/102#issuecomment-77995623
LGTM, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8299: Adding additional test c...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/102#issuecomment-77995716
@gauravaradhye your patch fails for 4.5, do you want to add test on 4.5 branch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8299: Adding additional test c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/102
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8299: Adding additional test c...
Posted by gauravaradhye <gi...@git.apache.org>.
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/102#issuecomment-78430462
No, this is not intended for 4.5. I have not tested on 4.5.
Regards,
Gaurav
On Tue, Mar 10, 2015 at 10:22 AM, Rohit Yadav <no...@github.com>
wrote:
> @gauravaradhye <https://github.com/gauravaradhye> your patch fails for
> 4.5, do you want to add test on 4.5 branch?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cloudstack/pull/102#issuecomment-77995716>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---