[GitHub] [superset] villebro commented on pull request #18746: fix(mssql): support top syntax for limiting queries

[GitBox <gi...@apache.org>]

villebro commented on pull request #18746:
URL: https://github.com/apache/superset/pull/18746#issuecomment-1044478013


   @dmcnulla this PR generalizes the work you did in #18240 to make it work for MSSQL, too. Would you be able to review this PR, and better yet test it on Teradata to ensure it still works as intended? Also notice the updated Teradata unit tests (I pushed a few new ones to this PR as I noticed the `SAMPLE` keyword wasn't covered by the existing tests).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org