You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/01/31 12:42:38 UTC
[GitHub] [cloudstack] Pearl1594 opened a new issue #5913: Support setting boot parameter via template settings
Pearl1594 opened a new issue #5913:
URL: https://github.com/apache/cloudstack/issues/5913
<!--
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release and main branch are affected too.
Always add information AFTER of these HTML comments, but no need to delete the comments.
-->
##### ISSUE TYPE
<!-- Pick one below and delete the rest -->
* Enhancement Request
##### COMPONENT NAME
<!--
Categorize the issue, e.g. API, VR, VPN, UI, etc.
-->
~~~
template, VM
~~~
##### CLOUDSTACK VERSION
<!--
New line separated list of affected versions, commit ID for issues on main branch.
-->
~~~
ACS 4.15.2
~~~
##### CONFIGURATION
<!--
Information about the configuration if relevant, e.g. basic network, advanced networking, etc. N/A otherwise
-->
##### OS / ENVIRONMENT
<!--
Information about the environment if relevant, N/A otherwise
hypervisor: VMWare
-->
##### SUMMARY
<!-- Explain the problem/feature briefly -->
When a template is configured with UEFI setting - UEFI=secure and a VM is deployed with the template, the boot parameters passed via the template settings does not take effect on the first boot. However, powering off the VM and restarting it, will bring up the instance using UEFI i.e., the template settings take effect
##### STEPS TO REPRODUCE
<!--
For bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.
For new features, show how the feature would be used.
-->
<!-- Paste example playbooks or commands between quotes below -->
~~~
1. Register a template as deploy-as-is and specify UEFI=SECURE in the template settings
2. Deploy a VM using the above registered template - VM doesn't boot using uefi
3. Stop & start the VM - the boot parameters are considered
~~~
<!-- You can also paste gist.github.com links for larger files -->
##### EXPECTED RESULTS
<!-- What did you expect to happen when running the steps above? -->
~~~
Consider template settings on the initial boot, or if not possible, prompt the user (by means of logs) that the specific setting wasn't considered
~~~
##### ACTUAL RESULTS
<!-- What actually happened? -->
<!-- Paste verbatim command output between quotes below -->
~~~
~~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on issue #5913: Support setting boot parameter via template settings
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #5913:
URL: https://github.com/apache/cloudstack/issues/5913#issuecomment-1029810941
But yes, after stopping VM, editing the VM settings (not the template settings), then some/all of those should apply (I know some do not apply, such as disk controller change, etc)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #5913: Support setting boot parameter via template settings
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #5913:
URL: https://github.com/apache/cloudstack/issues/5913#issuecomment-1025713769
@Pearl1594 this warrants a discussion on the functionality; if it is a deploy-as-is template, the contents of the template should be honoured. I.E. it should not be altered during initial instantiation. Altering it after that no longer has anything to do with the template and is ok, afaiac.
We should either forbid altering parameters on a deploy as is template or make very explicit what is going on (and maybe apply it immediately.
what you encountered is a strange situation but is as designed, i think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez edited a comment on issue #5913: Support setting boot parameter via template settings
Posted by GitBox <gi...@apache.org>.
nvazquez edited a comment on issue #5913:
URL: https://github.com/apache/cloudstack/issues/5913#issuecomment-1030637545
Sorry @kricud - when @andrijapanicsb and I mentioned 'deploy-as-is', we are meaning 'Read VM settings from OVA'. When you select this option, CloudStack won't let you select any setting and will clone the OVA template without any modification to its controllers or boot type.
In the image you shared the option is not selected, which allows to select controller as expected. Are you proposing to also allow to select the boot type in that UI wizard?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] kricud commented on issue #5913: Support setting boot parameter via template settings
Posted by GitBox <gi...@apache.org>.
kricud commented on issue #5913:
URL: https://github.com/apache/cloudstack/issues/5913#issuecomment-1030647796
Thant you @nvazquez for explain I have understood it incorrectly and base on that answered wrong also to @andrijapanicsb and @DaanHoogland
In #5932 I’m showing that if you add UEFI/SECURE to template settings it’s not working.
Adding this selection to template upload menu would make it admin friendly.
Making it work from temple settings also would work and maybe with this it can be assigned to 4.16.1 - if its fast fix.
Now I also agree with you that ‘’deploy-as-is/Read VM settings from OVA’’ is working exactly as it should work
and all settings must be taken from OVA.
@Pearl1594 There are many vendor OVA with custom settings for example from Juniper/PaloAlto/Aruba/Cisco that contain specific settings to run appliance and without ‘’deploy-as-is/Read VM settings from OVA’’ it would be close to impossible run them on ACS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on issue #5913: Support setting boot parameter via template settings
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #5913:
URL: https://github.com/apache/cloudstack/issues/5913#issuecomment-1029526977
I agree with @DaanHoogland, however I think it is a bug as per design boot parameters should not be considered on deploy-as-is VMs IMO. @borisstoyanov @rohityadavcloud @andrijapanicsb what's your input on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on issue #5913: Support setting boot parameter via template settings
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #5913:
URL: https://github.com/apache/cloudstack/issues/5913#issuecomment-1029809855
@kricud you are wrong/missing the point:
when "read VM settings from OVA" is ticked/selected - than all the template details come from the OVF (OVA) file - and nothing can be set as template details in ACS (i.e. you can't chose OS type, disk controllers, nic controller, etc, and also can't chose bios vs uefi)
when "read VM setting from OVA" is NOT ticked/selcted - then yes, whatever is configured in ACS as the template properties, should apply.
This is how it is supposed to work, by design (i.e. supply template details from ACS vs supplying those via OVF/OVA)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez closed issue #5913: Support setting boot parameter via template settings
Posted by GitBox <gi...@apache.org>.
nvazquez closed issue #5913:
URL: https://github.com/apache/cloudstack/issues/5913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on issue #5913: Support setting boot parameter via template settings
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #5913:
URL: https://github.com/apache/cloudstack/issues/5913#issuecomment-1030637545
Sorry @kricud - when @andrijapanicsb and I mentioned 'deploy-as-is', we are meaning 'Read VM settings from OVA'. When you select this option, the CloudStack won't let you select any setting and will clone the OVA template without any modification to its controllers or boot type
In the image you shared the option is not selected, which allows to select controller as expected. Are you proposing to also allow to select the boot type in that UI wizard?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] kricud edited a comment on issue #5913: Support setting boot parameter via template settings
Posted by GitBox <gi...@apache.org>.
kricud edited a comment on issue #5913:
URL: https://github.com/apache/cloudstack/issues/5913#issuecomment-1029949916
@andrijapanicsb @nvazquez
In case of deploy-as-is “Root disk controller” and “NIC adapter type” are set from template settings.
Same can be done for BIOS, UEFI/SECURE
It hasn’t been communicated clearly - reason for this need of setting boot type is that
Windows and also Linux for BIOS has one partitioning and for UEFI/SECURE another and they
are not compatible, you cant switch between them seamlessly.
For BIOS:
Linux: /boot, /
Win: System Reserved, OS partition
For EFI:
Linux: /boot , /boot/efi, /
Win: EFI system Partition, OS partition, Recovery Partition
(why recovery partition now is at end is another topic)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez edited a comment on issue #5913: Support setting boot parameter via template settings
Posted by GitBox <gi...@apache.org>.
nvazquez edited a comment on issue #5913:
URL: https://github.com/apache/cloudstack/issues/5913#issuecomment-1029526977
I agree with @DaanHoogland, however I think it is a bug as per design boot parameters should not be considered on deploy-as-is VMs on any case. @borisstoyanov @rohityadavcloud @andrijapanicsb what's your input on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on issue #5913: Support setting boot parameter via template settings
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #5913:
URL: https://github.com/apache/cloudstack/issues/5913#issuecomment-1029832207
Thanks @kricud @andrijapanicsb - so you are saying it is ok that CloudStack applies VM settings on stopped deploy-as-is VM? In this case, this is not a bug then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] kricud commented on issue #5913: Support setting boot parameter via template settings
Posted by GitBox <gi...@apache.org>.
kricud commented on issue #5913:
URL: https://github.com/apache/cloudstack/issues/5913#issuecomment-1029800471
@andrijapanicsb @DaanHoogland @nvazquez
Compromise could be that if deployment wizards see that template settings contain UEFI/SECURE it changes them to UEFI/SECURE, and if users changes them to BIOS deployment wizard assumes that he knows what he is doing and obeys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] kricud commented on issue #5913: Support setting boot parameter via template settings
Posted by GitBox <gi...@apache.org>.
kricud commented on issue #5913:
URL: https://github.com/apache/cloudstack/issues/5913#issuecomment-1029929898
If it would be only for admins not users/customers it would be ok to instruct every admin
and force him red manual from cover to cover and shame him if he hasn’t done that.
Not in case of users/customers.
For windows I need two templates one for BIOS and one for UEFI/SECURE.
As BIOS is legacy (this can be argued lets assume that it is) we are dropping support for it.
We have templates only with UEFI/SECURE and maybe after 10 years
all of ours VM will use UEFI/SECURE as no one will intentionally reinstall working BIOS VM to UEFI.
In its existing state it’s not possible to make seamless user-friendly experience
when template is prepared for UEFI/SECURE it is deployed with it by default from first start.
No users intervention is needed.
And I don’t have ticket, from every new customer who doesn’t know that he must set UEFI/SECURE
for this templet or it will not boot, in service desk system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on issue #5913: Support setting boot parameter via template settings
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #5913:
URL: https://github.com/apache/cloudstack/issues/5913#issuecomment-1029721562
with deployasis, everything should be honoured from the template, NOT from the template settings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] kricud commented on issue #5913: Support setting boot parameter via template settings
Posted by GitBox <gi...@apache.org>.
kricud commented on issue #5913:
URL: https://github.com/apache/cloudstack/issues/5913#issuecomment-1029789453
IMHO- template settings should be honored.
How I will explain to end users/customers that this template is for BIOS and this one is for UEFI and if you do not do correct selection, it will not boot.
I think it’s a bug that deployment wizard is not obeying settings from template.
If its not "Read VM settings from OVA" with this all settings should come from OVA.
Create #5932 same problem different description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] kricud commented on issue #5913: Support setting boot parameter via template settings
Posted by GitBox <gi...@apache.org>.
kricud commented on issue #5913:
URL: https://github.com/apache/cloudstack/issues/5913#issuecomment-1029949916
@andrijapanicsb @nvazquez
In case of deploy-as-is “Root disk controller” and “NIC adapter type” are set from template settings.
Same can be done for BIOS, UEFI/SECURE
It hasn’t been communicated clearly - reason for this need of setting boot type is that
Windows and also Linux for BIOS has one partitioning and for UEFI/SECURE another and they
are not compatible, you cant switch between them seamlessly.
For BIOS:
Linux: /boot, /
Win: System Reserved, OS partition
For EFI:
Linux: /boot , /boot/efi
Win: EFI system Partition, OS partition, Recovery Partition
(why recovery partition now is at end is another topic)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez edited a comment on issue #5913: Support setting boot parameter via template settings
Posted by GitBox <gi...@apache.org>.
nvazquez edited a comment on issue #5913:
URL: https://github.com/apache/cloudstack/issues/5913#issuecomment-1030637545
Sorry @kricud - when @andrijapanicsb and I mentioned 'deploy-as-is', we are meaning 'Read VM settings from OVA'. When you select this option, CloudStack won't let you select any setting and will clone the OVA template without any modification to its controllers or boot type
In the image you shared the option is not selected, which allows to select controller as expected. Are you proposing to also allow to select the boot type in that UI wizard?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org