You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/31 07:55:19 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request #32709: [WIP][SPARK-35573][R] Support R 4.1.0 in SparkR

HyukjinKwon opened a new pull request #32709:
URL: https://github.com/apache/spark/pull/32709


   ### What changes were proposed in this pull request?
   
   This PR proposes to support R 4.1.0+ in SparkR. Currently the tests are being failed as below:
   
   ```
   ══ Failed ══════════════════════════════════════════════════════════════════════
   ── 1. Failure (test_sparkSQL_arrow.R:71:3): createDataFrame/collect Arrow optimi
   collect(createDataFrame(rdf)) not equal to `expected`.
   Component “g”: 'tzone' attributes are inconsistent ('UTC' and '')
   
   ── 2. Failure (test_sparkSQL_arrow.R:143:3): dapply() Arrow optimization - type
   collect(ret) not equal to `rdf`.
   Component “b”: 'tzone' attributes are inconsistent ('UTC' and '')
   
   ── 3. Failure (test_sparkSQL_arrow.R:229:3): gapply() Arrow optimization - type
   collect(ret) not equal to `rdf`.
   Component “b”: 'tzone' attributes are inconsistent ('UTC' and '')
   
   ── 4. Error (test_sparkSQL.R:1454:3): column functions ─────────────────────────
   Error: (converted from warning) cannot xtfrm data frames
   Backtrace:
     1. base::sort(collect(distinct(select(df, input_file_name())))) test_sparkSQL.R:1454:2
     2. base::sort.default(collect(distinct(select(df, input_file_name()))))
     5. base::order(x, na.last = na.last, decreasing = decreasing)
     6. base::lapply(z, function(x) if (is.object(x)) as.vector(xtfrm(x)) else x)
     7. base:::FUN(X[[i]], ...)
    10. base::xtfrm.data.frame(x)
   ```
   
   ### Why are the changes needed?
   
   Higher R versions have bug fixes and improvements. More importantly R users tend to use highest R versions.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes, SparkR will work together with R 4.1.0+
   
   ### How was this patch tested?
   
   CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851504875


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139116/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851470652


   **[Test build #139116 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139116/testReport)** for PR 32709 at commit [`2f3cec2`](https://github.com/apache/spark/commit/2f3cec2f91d4e01e5d5d75e5f8ffe0ae65b34528).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon removed a comment on pull request #32709: [WIP][SPARK-35573][R] Support R 4.1.0 in SparkR

Posted by GitBox <gi...@apache.org>.
HyukjinKwon removed a comment on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851287095


   I'll take a look in CI. If it's simple, i will just fix it here. the PR uses my resource in the forked repository anyway :-).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #32709:
URL: https://github.com/apache/spark/pull/32709


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on a change in pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #32709:
URL: https://github.com/apache/spark/pull/32709#discussion_r642620515



##########
File path: R/pkg/tests/fulltests/test_sparkSQL.R
##########
@@ -1451,7 +1451,7 @@ test_that("column functions", {
   expect_equal(collect(df2)[[3, 2]], TRUE)
 
   # Test that input_file_name()
-  actual_names <- sort(collect(distinct(select(df, input_file_name()))))

Review comment:
       Oh yea, it is verified the length is 1. So removing sort looks good.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851470652


   **[Test build #139116 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139116/testReport)** for PR 32709 at commit [`2f3cec2`](https://github.com/apache/spark/commit/2f3cec2f91d4e01e5d5d75e5f8ffe0ae65b34528).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32709: [WIP][SPARK-35573][R] Support R 4.1.0 in SparkR

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851403231






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851539686






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a change in pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32709:
URL: https://github.com/apache/spark/pull/32709#discussion_r642458108



##########
File path: R/pkg/tests/fulltests/test_sparkSQL.R
##########
@@ -1451,7 +1451,7 @@ test_that("column functions", {
   expect_equal(collect(df2)[[3, 2]], TRUE)
 
   # Test that input_file_name()
-  actual_names <- sort(collect(distinct(select(df, input_file_name()))))

Review comment:
       It was sorting a DataFrame in R which isn't legitimate. In addition, there's no point of sorting. It's a single value single column DataFrame.
   
   ```
                                                                                          input_file_name()
   1 file:///private/var/folders/0c/q8y15ybd3tn7sr2_jmbmftr80000gp/T/RtmpwPkEnu/sparkr-testf2872350813d.tmp
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851745373


   I have backported it to branch-3.1 and branch-3.0 too because this is a test-only, and in case other people run the tests with higher R versions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32709: [WIP][SPARK-35573][R] Support R 4.1.0 in SparkR

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851287479


   **[Test build #139099 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139099/testReport)** for PR 32709 at commit [`ec08067`](https://github.com/apache/spark/commit/ec080671ddcc293b56db51bc35a3052c174505c0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851470529


   cc @shivaram, @felixcheung @falaki FYI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851504875


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139116/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a change in pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32709:
URL: https://github.com/apache/spark/pull/32709#discussion_r642465330



##########
File path: R/pkg/tests/fulltests/test_sparkSQL_arrow.R
##########
@@ -68,7 +68,7 @@ test_that("createDataFrame/collect Arrow optimization - type specification", {
     callJMethod(conf, "set", "spark.sql.execution.arrow.sparkr.enabled", arrowEnabled)
   })
 
-  expect_equal(collect(createDataFrame(rdf)), expected)
+  expect_true(all(collect(createDataFrame(rdf)) == expected))

Review comment:
       cc @MaxGekk FYI @BryanCutler too.

##########
File path: R/pkg/tests/fulltests/test_sparkSQL_arrow.R
##########
@@ -68,7 +68,7 @@ test_that("createDataFrame/collect Arrow optimization - type specification", {
     callJMethod(conf, "set", "spark.sql.execution.arrow.sparkr.enabled", arrowEnabled)
   })
 
-  expect_equal(collect(createDataFrame(rdf)), expected)
+  expect_true(all(collect(createDataFrame(rdf)) == expected))

Review comment:
       cc @MaxGekk @BryanCutler FYI.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32709: [WIP][SPARK-35573][R] Support R 4.1.0 in SparkR

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851378560


   **[Test build #139108 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139108/testReport)** for PR 32709 at commit [`c573435`](https://github.com/apache/spark/commit/c573435677fd60a18dbbda5e4840af00c2ad5c7b).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32709: [WIP][SPARK-35573][R] Support R 4.1.0 in SparkR

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851336385


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43620/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32709: [WIP][SPARK-35573][R] Support R 4.1.0 in SparkR

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851361084


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43620/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851510697


   **[Test build #139117 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139117/testReport)** for PR 32709 at commit [`97f3c0e`](https://github.com/apache/spark/commit/97f3c0e0ef828a4374b2ed5740aac929c3597574).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #32709: [WIP][SPARK-35573][R] Support R 4.1.0 in SparkR

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851287095


   I'll take a look in CI. If it's simple, i will just fix it here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851896678


   Nice! Thank you so much!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32709: [WIP][SPARK-35573][R] Support R 4.1.0 in SparkR

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851435599


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43628/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32709: [WIP][SPARK-35573][R] Support R 4.1.0 in SparkR

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851378560


   **[Test build #139108 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139108/testReport)** for PR 32709 at commit [`c573435`](https://github.com/apache/spark/commit/c573435677fd60a18dbbda5e4840af00c2ad5c7b).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851744847






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32709: [WIP][SPARK-35573][R] Support R 4.1.0 in SparkR

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851381764


   **[Test build #139108 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139108/testReport)** for PR 32709 at commit [`c573435`](https://github.com/apache/spark/commit/c573435677fd60a18dbbda5e4840af00c2ad5c7b).
    * This patch **fails to build**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851538106


   Kubernetes integration test unable to build dist.
   
   exiting with code: 1
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43637/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on a change in pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #32709:
URL: https://github.com/apache/spark/pull/32709#discussion_r642620155



##########
File path: R/pkg/tests/fulltests/test_sparkSQL.R
##########
@@ -1451,7 +1451,7 @@ test_that("column functions", {
   expect_equal(collect(df2)[[3, 2]], TRUE)
 
   # Test that input_file_name()
-  actual_names <- sort(collect(distinct(select(df, input_file_name()))))

Review comment:
       Not sure if it is intentional to be a single value? Because it is `actual_names`. :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a change in pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32709:
URL: https://github.com/apache/spark/pull/32709#discussion_r642510089



##########
File path: R/pkg/tests/fulltests/test_utils.R
##########
@@ -64,7 +64,12 @@ test_that("cleanClosure on R functions", {
   actual <- get("y", envir = env, inherits = FALSE)
   expect_equal(actual, y)
   actual <- get("g", envir = env, inherits = FALSE)
-  expect_equal(actual, g)
+  if (as.numeric(R.Version()$major) >= 4 && !startsWith(R.Version()$minor, "0")) {
+    # 4.1+ checks environment in the function
+    expect_true(all.equal(actual, g, check.environment = FALSE))

Review comment:
       This also seems like `testthat` uses `all.equal` internally which now compares environment of the functions (previously it didn't):
   
   > all.equal(f, g) for functions now by default also compares their environment(.)s, notably via new all.equal method for class function. Comparison of nls() fits, e.g., may now need all.equal(m1, m2, check.environment = FALSE).
   
   https://cran.r-project.org/doc/manuals/r-release/NEWS.html




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32709: [WIP][SPARK-35573][R] Support R 4.1.0 in SparkR

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851405815


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43628/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851788514


   Cool! Thanks @HyukjinKwon!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a change in pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32709:
URL: https://github.com/apache/spark/pull/32709#discussion_r642465330



##########
File path: R/pkg/tests/fulltests/test_sparkSQL_arrow.R
##########
@@ -68,7 +68,7 @@ test_that("createDataFrame/collect Arrow optimization - type specification", {
     callJMethod(conf, "set", "spark.sql.execution.arrow.sparkr.enabled", arrowEnabled)
   })
 
-  expect_equal(collect(createDataFrame(rdf)), expected)
+  expect_true(all(collect(createDataFrame(rdf)) == expected))

Review comment:
       cc @MaxGekk FYI




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a change in pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32709:
URL: https://github.com/apache/spark/pull/32709#discussion_r642464454



##########
File path: R/pkg/tests/fulltests/test_sparkSQL_arrow.R
##########
@@ -68,7 +68,7 @@ test_that("createDataFrame/collect Arrow optimization - type specification", {
     callJMethod(conf, "set", "spark.sql.execution.arrow.sparkr.enabled", arrowEnabled)
   })
 
-  expect_equal(collect(createDataFrame(rdf)), expected)
+  expect_true(all(collect(createDataFrame(rdf)) == expected))

Review comment:
       Here I work around to make the tests work with any R version. The problem was [R 4.1 introduced `check.tzone` at `all.equal`](https://cran.r-project.org/doc/manuals/r-release/NEWS.html) which apparently `testthat` uses.
   
   When you collect from a POSIXct with an empty tzone (by default), Arrow conversion fills a local timezone instead of being empty:
   
   ```r
   rdf <- data.frame(list(list(t = as.POSIXct("1990-02-24 12:34:56", tz="UTC"))))
   SparkR:::callJMethod(SparkR:::callJMethod(spark, "conf"), "set", "spark.sql.execution.arrow.sparkr.enabled", "false")
   withoutArrow <- collect(createDataFrame(rdf))
   SparkR:::callJMethod(SparkR:::callJMethod(spark, "conf"), "set", "spark.sql.execution.arrow.sparkr.enabled", "true")
   withArrow <- collect(createDataFrame(rdf))
   
   attr(withoutArrow$t, "tzone")
   attr(withArrow$t, "tzone")
   ```
   ```
   [1] ""
   [1] "Asia/Seoul"
   ```
   
    Spark returns a local time instances in Scala, Python and R. Therefore, I think either being an empty timezone or local timezone can be correct in Spark context, and it's not an issue IMO.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851530788


   **[Test build #139117 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139117/testReport)** for PR 32709 at commit [`97f3c0e`](https://github.com/apache/spark/commit/97f3c0e0ef828a4374b2ed5740aac929c3597574).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851498562


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43636/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32709: [WIP][SPARK-35573][R] Support R 4.1.0 in SparkR

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851424007


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43628/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon edited a comment on pull request #32709: [WIP][SPARK-35573][R] Support R 4.1.0 in SparkR

Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851287095


   I'll take a look in CI. If it's simple, i will just fix it here. the PR uses my resource in the forked repository anyway :-).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32709: [WIP][SPARK-35573][R] Support R 4.1.0 in SparkR

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851369735


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43620/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32709: [WIP][SPARK-35573][R] Support R 4.1.0 in SparkR

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851369735


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43620/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #32709: [WIP][SPARK-35573][R] Support R 4.1.0 in SparkR

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851287531


   I'll take a look in CI. If it's simple, i will just fix it here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851498302


   **[Test build #139116 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139116/testReport)** for PR 32709 at commit [`2f3cec2`](https://github.com/apache/spark/commit/2f3cec2f91d4e01e5d5d75e5f8ffe0ae65b34528).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851519230


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43636/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a change in pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32709:
URL: https://github.com/apache/spark/pull/32709#discussion_r642464454



##########
File path: R/pkg/tests/fulltests/test_sparkSQL_arrow.R
##########
@@ -68,7 +68,7 @@ test_that("createDataFrame/collect Arrow optimization - type specification", {
     callJMethod(conf, "set", "spark.sql.execution.arrow.sparkr.enabled", arrowEnabled)
   })
 
-  expect_equal(collect(createDataFrame(rdf)), expected)
+  expect_true(all(collect(createDataFrame(rdf)) == expected))

Review comment:
       Here I work around to make the tests work with any R version. The problem was [R 4.1 introduced `check.tzone` at `all.equal`](https://cran.r-project.org/doc/manuals/r-release/NEWS.html) which apparently `testthat` uses.
   
   When you collect from a POSIXct with an empty tzone (by default), Arrow conversion fills a local timezone instead of being empty:
   
   ```r
   rdf <- data.frame(list(list(t = as.POSIXct("1990-02-24 12:34:56", tz="UTC"))))
   SparkR:::callJMethod(SparkR:::callJMethod(spark, "conf"), "set", "spark.sql.execution.arrow.sparkr.enabled", "false")
   withoutArrow <- collect(createDataFrame(rdf))
   SparkR:::callJMethod(SparkR:::callJMethod(spark, "conf"), "set", "spark.sql.execution.arrow.sparkr.enabled", "true")
   withArrow <- collect(createDataFrame(rdf))
   
   attr(withoutArrow$t, "tzone")
   attr(withArrow$t, "tzone")
   ```
   ```
   [1] ""
   [1] "Asia/Seoul"
   ```
   
   Spark returns a local time instances in Scala, Python and R. Therefore, I think either being an empty timezone or local timezone can be correct in Spark context, and it's not an issue IMO.
   
   FWIW, we're the one who sets the timezone on JVM side if I remember all correctly.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851539682






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32709: [WIP][SPARK-35573][R] Support R 4.1.0 in SparkR

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851401145


   **[Test build #139099 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139099/testReport)** for PR 32709 at commit [`ec08067`](https://github.com/apache/spark/commit/ec080671ddcc293b56db51bc35a3052c174505c0).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #32709: [WIP][SPARK-35573][R] Support R 4.1.0 in SparkR

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851288457


   Thanks, @HyukjinKwon !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851510697


   **[Test build #139117 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139117/testReport)** for PR 32709 at commit [`97f3c0e`](https://github.com/apache/spark/commit/97f3c0e0ef828a4374b2ed5740aac929c3597574).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32709: [WIP][SPARK-35573][R] Support R 4.1.0 in SparkR

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851435599


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43628/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32709: [WIP][SPARK-35573][R] Support R 4.1.0 in SparkR

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851403231






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32709: [WIP][SPARK-35573][R] Support R 4.1.0 in SparkR

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851287479


   **[Test build #139099 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139099/testReport)** for PR 32709 at commit [`ec08067`](https://github.com/apache/spark/commit/ec080671ddcc293b56db51bc35a3052c174505c0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32709:
URL: https://github.com/apache/spark/pull/32709#issuecomment-851778790


   CRAN was my env issue. Now the tests and CRAN check should work with R 4.1+ too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org