[GitHub] HyukjinKwon commented on a change in pull request #23736: [SPARK-26831][PYTHON] bin/pyspark: eliminate use of hardcoded 'python' command and fix IPython version check

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #23736: [SPARK-26831][PYTHON] bin/pyspark: eliminate use of hardcoded 'python' command and fix IPython version check
URL: https://github.com/apache/spark/pull/23736#discussion_r254195623
 
 

 ##########
 File path: bin/pyspark
 ##########
 @@ -42,11 +42,10 @@ if [[ -z "$PYSPARK_DRIVER_PYTHON" ]]; then
   PYSPARK_DRIVER_PYTHON="${PYSPARK_PYTHON:-"python"}"
 fi
 
-WORKS_WITH_IPYTHON=$(python -c 'import sys; print(sys.version_info >= (2, 7, 0))')
-
 # Determine the Python executable to use for the executors:
 if [[ -z "$PYSPARK_PYTHON" ]]; then
-  if [[ $PYSPARK_DRIVER_PYTHON == *ipython* && ! $WORKS_WITH_IPYTHON ]]; then
+  WORKS_WITH_IPYTHON=$(python -c 'import sys; print(sys.version_info >= (2, 7, 0))')
 
 Review comment:
   cc @JoshRosen am I getting this correct? Looks weird that it checks `python` at driver when `PYSPARK_DRIVER_PYTHON` is set to IPython.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org