You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Caideyipi (via GitHub)" <gi...@apache.org> on 2026/06/16 11:00:48 UTC
[PR] Fix idempotent table cache update handling [iotdb]
Caideyipi opened a new pull request, #17959:
URL: https://github.com/apache/iotdb/pull/17959
This PR makes DataNode table cache update handling idempotent when a commit or rollback update request is repeated or arrives after the pre-update entry has already been cleared. commitUpdateTable previously read the pre-update table and wrote it into a ConcurrentHashMap without checking for null, so a delayed duplicate commit could throw an NPE after the entry was already handled. The change treats missing or cleared pre-update entries as already handled and makes removeTableFromPreUpdateMap tolerant of absent entries. Tests: mvn -pl iotdb-core/datanode -am -Dtest=DataNodeTableCacheTest -DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false -Dspotless.skip=true -Dcheckstyle.skip=true test -DskipITs; mvn -pl iotdb-core/datanode -DskipTests -DskipITs spotless:check checkstyle:check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix idempotent table cache update handling [iotdb]
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 merged PR #17959:
URL: https://github.com/apache/iotdb/pull/17959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org