You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/28 07:14:46 UTC
[GitHub] [apisix] rapiz1 opened a new pull request #5229: feat: support `make uninstall`
rapiz1 opened a new pull request #5229:
URL: https://github.com/apache/apisix/pull/5229
Support `make uninstall` by simplying removing installed files and
directories. Currently the installation can be simply reversed in this way
as well as not introducing too much duplicated code.
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
Resolves https://github.com/apache/apisix/issues/5225
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #5229: feat: support `make uninstall`
Posted by GitBox <gi...@apache.org>.
leslie-tsang commented on a change in pull request #5229:
URL: https://github.com/apache/apisix/pull/5229#discussion_r728878847
##########
File path: Makefile
##########
@@ -331,6 +331,12 @@ install: runtime
$(INSTALL) -d $(INST_LUADIR)/apisix/plugins/slslog
$(INSTALL) apisix/plugins/slslog/*.lua $(INST_LUADIR)/apisix/plugins/slslog/
+.PHONY: uninstall
Review comment:
```suggestion
### uninstall : Uninstall the apisix
.PHONY: uninstall
```
Comment for target `help` in need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] rapiz1 commented on a change in pull request #5229: feat: support `make uninstall`
Posted by GitBox <gi...@apache.org>.
rapiz1 commented on a change in pull request #5229:
URL: https://github.com/apache/apisix/pull/5229#discussion_r728895981
##########
File path: Makefile
##########
@@ -331,6 +331,12 @@ install: runtime
$(INSTALL) -d $(INST_LUADIR)/apisix/plugins/slslog
$(INSTALL) apisix/plugins/slslog/*.lua $(INST_LUADIR)/apisix/plugins/slslog/
+.PHONY: uninstall
+uninstall:
+ rm -rf $(INST_LUADIR)/apisix
+ rm -rf /usr/local/apisix/
Review comment:
Then `install` should also be changed. I suggest changing that in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5229: feat: support `make uninstall`
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #5229:
URL: https://github.com/apache/apisix/pull/5229#discussion_r728864520
##########
File path: Makefile
##########
@@ -331,6 +331,12 @@ install: runtime
$(INSTALL) -d $(INST_LUADIR)/apisix/plugins/slslog
$(INSTALL) apisix/plugins/slslog/*.lua $(INST_LUADIR)/apisix/plugins/slslog/
+.PHONY: uninstall
+uninstall:
+ rm -rf $(INST_LUADIR)/apisix
+ rm -rf /usr/local/apisix/
Review comment:
why delete this absolute path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5229: feat: support `make uninstall`
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #5229:
URL: https://github.com/apache/apisix/pull/5229#discussion_r728889469
##########
File path: Makefile
##########
@@ -331,6 +331,12 @@ install: runtime
$(INSTALL) -d $(INST_LUADIR)/apisix/plugins/slslog
$(INSTALL) apisix/plugins/slslog/*.lua $(INST_LUADIR)/apisix/plugins/slslog/
+.PHONY: uninstall
+uninstall:
+ rm -rf $(INST_LUADIR)/apisix
+ rm -rf /usr/local/apisix/
Review comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on pull request #5229: feat: support `make uninstall`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #5229:
URL: https://github.com/apache/apisix/pull/5229#issuecomment-993378556
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander closed pull request #5229: feat: support `make uninstall`
Posted by GitBox <gi...@apache.org>.
spacewander closed pull request #5229:
URL: https://github.com/apache/apisix/pull/5229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on pull request #5229: feat: support `make uninstall`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #5229:
URL: https://github.com/apache/apisix/pull/5229#issuecomment-1009794689
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] github-actions[bot] closed pull request #5229: feat: support `make uninstall`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #5229:
URL: https://github.com/apache/apisix/pull/5229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] rapiz1 commented on a change in pull request #5229: feat: support `make uninstall`
Posted by GitBox <gi...@apache.org>.
rapiz1 commented on a change in pull request #5229:
URL: https://github.com/apache/apisix/pull/5229#discussion_r728876356
##########
File path: Makefile
##########
@@ -331,6 +331,12 @@ install: runtime
$(INSTALL) -d $(INST_LUADIR)/apisix/plugins/slslog
$(INSTALL) apisix/plugins/slslog/*.lua $(INST_LUADIR)/apisix/plugins/slslog/
+.PHONY: uninstall
+uninstall:
+ rm -rf $(INST_LUADIR)/apisix
+ rm -rf /usr/local/apisix/
Review comment:
The absolute path `/usr/local/apisix/` is created by the `install` target. Do you imply it should respect `INST_PREFIX`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org