You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "uros-b (via GitHub)" <gi...@apache.org> on 2026/09/02 10:04:08 UTC

[PR] Common: Add missing Javadoc for Dyn* utility classes [iceberg]

uros-b opened a new pull request, #17922:
URL: https://github.com/apache/iceberg/pull/17922

   `build-javadoc` emits 41 doclint warnings (37 × `no comment`, 4 × `no @return`) for the public API of the `Dyn*` reflection utilities in `iceberg-common`: the Gradle `javadoc` task runs default doclint (`-Xdoclint:all`) with no suppression, so every undocumented `public`/`protected` element is flagged.
   
   This documents the flagged elements in `DynClasses`, `DynConstructors`, `DynFields` and `DynMethods` with complete Javadoc (summary + `@param`/`@return`/`@throws`, including type parameters), matching the style already used on their siblings (e.g. `DynMethods.Builder`). `@Override` methods are left as-is since they inherit their documentation. Javadoc-only — no signature or bytecode change; `./gradlew :iceberg-common:javadoc` is now warning-free.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Common: Add missing Javadoc for Dyn* utility classes [iceberg]

Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #17922:
URL: https://github.com/apache/iceberg/pull/17922#issuecomment-5551546321

   cc @szehon-ho 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Common: Add missing Javadoc for Dyn* utility classes [iceberg]

Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #17922:
URL: https://github.com/apache/iceberg/pull/17922#issuecomment-5567239016

   cc @huaxingao 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Common: Add missing Javadoc for Dyn* utility classes [iceberg]

Posted by "Akanksha-kedia (via GitHub)" <gi...@apache.org>.
Akanksha-kedia commented on PR #17922:
URL: https://github.com/apache/iceberg/pull/17922#issuecomment-5602476439

   Thanks!!!!!!
   
   On Wed, 9 Sep 2026 at 6:13 PM, Eduard Tudenhoefner ***@***.***>
   wrote:
   
   > ***@***.**** approved this pull request.
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/iceberg/pull/17922?email_source=notifications&email_token=AVL2AZXMQJ74LFPEG34HDT35OFF7DA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMJVGQZTKNBTGQYKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#pullrequestreview-5154354340>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AVL2AZWGFOGM4RJSCCAT23T5OFF7DAVCNFSNUABFKJSXA33TNF2G64TZHMYTKOBSGU3DINZZHNEXG43VMU5TKMZSGI2TCNBQGI42C5QC>
   > .
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Common: Add missing Javadoc for Dyn* utility classes [iceberg]

Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao commented on PR #17922:
URL: https://github.com/apache/iceberg/pull/17922#issuecomment-5605391721

   Thanks @uros-b for the PR! Thanks @nastra for the review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Common: Add missing Javadoc for Dyn* utility classes [iceberg]

Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #17922:
URL: https://github.com/apache/iceberg/pull/17922#issuecomment-5601874284

   soft ping for this ^^


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Common: Add missing Javadoc for Dyn* utility classes [iceberg]

Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao merged PR #17922:
URL: https://github.com/apache/iceberg/pull/17922


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org