You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2016/12/14 12:44:23 UTC

Review Request 54739: Used correct shell string comparison operator in test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54739/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar, Avinash sridharan, Jie Yu, and Till Toenshoff.


Repository: mesos


Description
-------

In order to compare two strings for equality in shell with the `[`
operator (which is often mapped to `test`), the `=` operator should be
used.

This patches replaces usage of `==` with `=` in one such comparison.
While on many system this appears to work with the shell mapped to
`sh`, it does not work for e.g., ubuntu which uses `dash` as the
default shell.


Diffs
-----

  src/tests/containerizer/cni_isolator_tests.cpp 0380f2ca122c7b8ab1dac351b14f546526580e72 

Diff: https://reviews.apache.org/r/54739/diff/


Testing
-------

Tested on various Linux flavors in internal CI.


Thanks,

Benjamin Bannier


Re: Review Request 54739: Used correct shell string comparison operator in test.

Posted by Till Toenshoff <to...@me.com>.

> On Dec. 14, 2016, 1:25 p.m., Till Toenshoff wrote:
> > thanks for cleaning up Benjamin - the CI and hence the entire team will appreciate :)

Quick note, Benjamin also did a quick sweep over the entire codebase to check for further instances of this issue and it seems we are good as all other instances (fetcher tests) were enforcing bash.


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54739/#review159142
-----------------------------------------------------------


On Dec. 14, 2016, 12:45 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54739/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2016, 12:45 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Avinash sridharan, Jie Yu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-6793
>     https://issues.apache.org/jira/browse/MESOS-6793
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In order to compare two strings for equality in shell with the `[`
> operator (which is often mapped to `test`), the `=` operator should be
> used.
> 
> This patches replaces usage of `==` with `=` in one such comparison.
> While on many system this appears to work with the shell mapped to
> `sh`, it does not work for e.g., ubuntu which uses `dash` as the
> default shell.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cni_isolator_tests.cpp 0380f2ca122c7b8ab1dac351b14f546526580e72 
> 
> Diff: https://reviews.apache.org/r/54739/diff/
> 
> 
> Testing
> -------
> 
> Tested on various Linux flavors in internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Re: Review Request 54739: Used correct shell string comparison operator in test.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54739/#review159142
-----------------------------------------------------------


Ship it!




thanks for cleaning up Benjamin - the CI and hence the entire team will appreciate :)

- Till Toenshoff


On Dec. 14, 2016, 12:45 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54739/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2016, 12:45 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Avinash sridharan, Jie Yu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-6793
>     https://issues.apache.org/jira/browse/MESOS-6793
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In order to compare two strings for equality in shell with the `[`
> operator (which is often mapped to `test`), the `=` operator should be
> used.
> 
> This patches replaces usage of `==` with `=` in one such comparison.
> While on many system this appears to work with the shell mapped to
> `sh`, it does not work for e.g., ubuntu which uses `dash` as the
> default shell.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cni_isolator_tests.cpp 0380f2ca122c7b8ab1dac351b14f546526580e72 
> 
> Diff: https://reviews.apache.org/r/54739/diff/
> 
> 
> Testing
> -------
> 
> Tested on various Linux flavors in internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Re: Review Request 54739: Used correct shell string comparison operator in test.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54739/
-----------------------------------------------------------

(Updated Dec. 14, 2016, 1:45 p.m.)


Review request for mesos, Anand Mazumdar, Avinash sridharan, Jie Yu, and Till Toenshoff.


Bugs: MESOS-6793
    https://issues.apache.org/jira/browse/MESOS-6793


Repository: mesos


Description
-------

In order to compare two strings for equality in shell with the `[`
operator (which is often mapped to `test`), the `=` operator should be
used.

This patches replaces usage of `==` with `=` in one such comparison.
While on many system this appears to work with the shell mapped to
`sh`, it does not work for e.g., ubuntu which uses `dash` as the
default shell.


Diffs
-----

  src/tests/containerizer/cni_isolator_tests.cpp 0380f2ca122c7b8ab1dac351b14f546526580e72 

Diff: https://reviews.apache.org/r/54739/diff/


Testing
-------

Tested on various Linux flavors in internal CI.


Thanks,

Benjamin Bannier