You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2023/01/11 23:39:54 UTC
[GitHub] [superset] dependabot[bot] opened a new pull request, #22697: build(deps): bump react-router-dom from 5.1.2 to 6.6.2 in /superset-frontend
dependabot[bot] opened a new pull request, #22697:
URL: https://github.com/apache/superset/pull/22697
Bumps [react-router-dom](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom) from 5.1.2 to 6.6.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/remix-run/react-router/releases">react-router-dom's releases</a>.</em></p>
<blockquote>
<h2>v6.4.4</h2>
<h2>What's Changed</h2>
<ul>
<li>Throw an error if an <code>action</code>/<code>loader</code> function returns <code>undefined</code> as revalidations need to know whether the loader has previously been executed. <code>undefined</code> also causes issues during SSR stringification for hydration. You should always ensure your <code>loader</code>/<code>action</code> returns a value, and you may return <code>null</code> if you don't wish to return anything. (<a href="https://github-redirect.dependabot.com/remix-run/react-router/pull/9511">#9511</a>)</li>
<li>Properly handle redirects to external domains (<a href="https://github-redirect.dependabot.com/remix-run/react-router/pull/9590">#9590</a>, <a href="https://github-redirect.dependabot.com/remix-run/react-router/pull/9654">#9654</a>)</li>
<li>Preserve the HTTP method on 307/308 redirects (<a href="https://github-redirect.dependabot.com/remix-run/react-router/pull/9597">#9597</a>)</li>
<li>Support <code>basename</code> in static data routers (<a href="https://github-redirect.dependabot.com/remix-run/react-router/pull/9591">#9591</a>)</li>
<li>Enhanced <code>ErrorResponse</code> bodies to contain more descriptive text in internal 403/404/405 scenarios</li>
<li>Fix issues with encoded characters in <code>NavLink</code> and descendant <code><Routes></code> (<a href="https://github-redirect.dependabot.com/remix-run/react-router/pull/9589">#9589</a>, <a href="https://github-redirect.dependabot.com/remix-run/react-router/pull/9647">#9647</a>)</li>
<li>Properly serialize/deserialize <code>ErrorResponse</code> instances when using built-in hydration (<a href="https://github-redirect.dependabot.com/remix-run/react-router/pull/9593">#9593</a>)</li>
<li>Support <code>basename</code> in static data routers (<a href="https://github-redirect.dependabot.com/remix-run/react-router/pull/9591">#9591</a>)</li>
<li>Updated dependencies:
<ul>
<li><code>@remix-run/router@1.0.4</code></li>
<li><code>react-router@6.4.4</code></li>
</ul>
</li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/remix-run/react-router/compare/react-router-dom@6.4.3...react-router-dom@6.4.4">https://github.com/remix-run/react-router/compare/react-router-dom@6.4.3...react-router-dom@6.4.4</a></p>
<h2>react-router-dom@6.4.0-pre.15</h2>
<h3>Patch Changes</h3>
<ul>
<li>
<p>fix: remove internal router singleton (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9227">#9227</a>)</p>
<p>This change removes the internal module-level <code>routerSingleton</code> we create and maintain inside our data routers since it was causing a number of headaches for non-simple use cases:</p>
<ul>
<li>Unit tests are a pain because you need to find a way to reset the singleton in-between tests
<ul>
<li>Use use a <code>_resetModuleScope</code> singleton for our tests</li>
<li>...but this isn't exposed to users who may want to do their own tests around our router</li>
</ul>
</li>
<li>The JSX children <code><Route></code> objects cause non-intuitive behavior based on idiomatic react expectations
<ul>
<li>Conditional runtime <code><Route></code>'s won't get picked up</li>
<li>Adding new <code><Route></code>'s during local dev won't get picked up during HMR</li>
<li>Using external state in your elements doesn't work as one might expect (see <a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9225">#9225</a>)</li>
</ul>
</li>
</ul>
<p>Instead, we are going to lift the singleton out into user-land, so that they create the router singleton and manage it outside the react tree - which is what react 18 is encouraging with <code>useSyncExternalStore</code> anyways! This also means that since users create the router - there's no longer any difference in the rendering aspect for memory/browser/hash routers (which only impacts router/history creation) - so we can get rid of those and trim to a simple <code>RouterProvider</code></p>
<pre lang="jsx"><code>// Before
function App() {
<DataBrowserRouter>
<Route path="/" element={<Layout />}>
<Route index element={<Home />}>
</Route>
<DataBrowserRouter>
}
<p>// After
let router = createBrowserRouter([{
path: "/",
element: <Layout />,
children: [{
index: true,
</code></pre></p>
</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/remix-run/react-router/blob/main/packages/react-router-dom/CHANGELOG.md">react-router-dom's changelog</a>.</em></p>
<blockquote>
<h2>6.6.2</h2>
<h3>Patch Changes</h3>
<ul>
<li>Ensure <code>useId</code> consistency during SSR (<a href="https://github-redirect.dependabot.com/remix-run/react-router/pull/9805">#9805</a>)</li>
<li>Updated dependencies:
<ul>
<li><code>react-router@6.6.2</code></li>
</ul>
</li>
</ul>
<h2>6.6.1</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies:
<ul>
<li><code>@remix-run/router@1.2.1</code></li>
<li><code>react-router@6.6.1</code></li>
</ul>
</li>
</ul>
<h2>6.6.0</h2>
<h3>Minor Changes</h3>
<ul>
<li>Add <code>useBeforeUnload()</code> hook (<a href="https://github-redirect.dependabot.com/remix-run/react-router/pull/9664">#9664</a>)</li>
<li>Remove <code>unstable_</code> prefix from <code>createStaticHandler</code>/<code>createStaticRouter</code>/<code>StaticRouterProvider</code> (<a href="https://github-redirect.dependabot.com/remix-run/react-router/pull/9738">#9738</a>)</li>
</ul>
<h3>Patch Changes</h3>
<ul>
<li>Proper hydration of <code>Error</code> objects from <code>StaticRouterProvider</code> (<a href="https://github-redirect.dependabot.com/remix-run/react-router/pull/9664">#9664</a>)</li>
<li>Support uppercase <code><Form method></code> and <code>useSubmit</code> method values (<a href="https://github-redirect.dependabot.com/remix-run/react-router/pull/9664">#9664</a>)</li>
<li>Skip initial scroll restoration for SSR apps with <code>hydrationData</code> (<a href="https://github-redirect.dependabot.com/remix-run/react-router/pull/9664">#9664</a>)</li>
<li>Fix <code><button formmethod></code> form submission overriddes (<a href="https://github-redirect.dependabot.com/remix-run/react-router/pull/9664">#9664</a>)</li>
<li>Updated dependencies:
<ul>
<li><code>@remix-run/router@1.2.0</code></li>
<li><code>react-router@6.6.0</code></li>
</ul>
</li>
</ul>
<h2>6.5.0</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies:
<ul>
<li><code>react-router@6.5.0</code></li>
<li><code>@remix-run/router@1.1.0</code></li>
</ul>
</li>
</ul>
<h2>6.4.5</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies:
<ul>
<li><code>@remix-run/router@1.0.5</code></li>
<li><code>react-router@6.4.5</code></li>
</ul>
</li>
</ul>
<h2>6.4.4</h2>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/remix-run/react-router/commit/8ce83ab87ff94ba736745b90bfbf2110892d4e6f"><code>8ce83ab</code></a> chore: Update version for release (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9838">#9838</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/8fb7921ec25423f3cd11a9e02f7ba49389a5ce85"><code>8fb7921</code></a> chore: Update version for release (pre) (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9816">#9816</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/ee2fc0ceb7e17aa4aa6fd07a1d4b5c7465926a8a"><code>ee2fc0c</code></a> Ensure consistent component tree for useId (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9805">#9805</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/baf69f02c643579844a84e85bfbf28a221bab627"><code>baf69f0</code></a> chore: Update version for release (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9786">#9786</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/cdb0592b923c321735fc6c8687a981b25a3aaeee"><code>cdb0592</code></a> chore: Update version for release (pre) (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9783">#9783</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/554aa84a39fdb48bafc599fd96a3b8f1bafbbb7d"><code>554aa84</code></a> chore: Update version for release (pre) (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9780">#9780</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/c3c2f29d2e56cd599c102ab1d9b955d1a19efc10"><code>c3c2f29</code></a> chore: Update version for release (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9771">#9771</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/19851411d9aa57f51cae0e988f1bd86fd4f4f7f8"><code>1985141</code></a> chore: Update version for release (pre) (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9742">#9742</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/da1e6e040ff919559eb2ada957ed1ad908e2650f"><code>da1e6e0</code></a> Stabilize SSR data router APIs (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9738">#9738</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/b714ec3a543cbb7a7a6fe3af97394fff3b2f2a3c"><code>b714ec3</code></a> Update replace logic for form submissions/redirects (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9734">#9734</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/remix-run/react-router/commits/react-router-dom@6.6.2/packages/react-router-dom">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lilykuang commented on pull request #22697: build(deps): bump react-router-dom from 5.1.2 to 6.6.2 in /superset-frontend
Posted by GitBox <gi...@apache.org>.
lilykuang commented on PR #22697:
URL: https://github.com/apache/superset/pull/22697#issuecomment-1385794470
yes, this is related to react 18 upgrade. also upgrading react-router-dom v5 to v6 has breaking changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #22697: build(deps): bump react-router-dom from 5.1.2 to 6.6.2 in /superset-frontend
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #22697:
URL: https://github.com/apache/superset/pull/22697#issuecomment-1385784842
@lilykuang should this be considered as part of the React 18 update project? Just seems... related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dependabot[bot] commented on pull request #22697: build(deps): bump react-router-dom from 5.1.2 to 6.6.2 in /superset-frontend
Posted by dependabot.
dependabot[bot] commented on PR #22697:
URL: https://github.com/apache/superset/pull/22697#issuecomment-1405332312
Superseded by #22874.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dependabot[bot] closed pull request #22697: build(deps): bump react-router-dom from 5.1.2 to 6.6.2 in /superset-frontend
Posted by dependabot.
dependabot[bot] closed pull request #22697: build(deps): bump react-router-dom from 5.1.2 to 6.6.2 in /superset-frontend
URL: https://github.com/apache/superset/pull/22697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org