You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2013/01/18 15:10:52 UTC

svn commit: r1435147 - /httpcomponents/httpcore/branches/4.2.x/httpcore/src/main/java/org/apache/http/concurrent/BasicFuture.java

Author: olegk
Date: Fri Jan 18 14:10:51 2013
New Revision: 1435147

URL: http://svn.apache.org/viewvc?rev=1435147&view=rev
Log:
HTTPCORE-331: BasicFuture no longer executes notification callbacks inside a synchronized block (cleanup)

Modified:
    httpcomponents/httpcore/branches/4.2.x/httpcore/src/main/java/org/apache/http/concurrent/BasicFuture.java

Modified: httpcomponents/httpcore/branches/4.2.x/httpcore/src/main/java/org/apache/http/concurrent/BasicFuture.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/branches/4.2.x/httpcore/src/main/java/org/apache/http/concurrent/BasicFuture.java?rev=1435147&r1=1435146&r2=1435147&view=diff
==============================================================================
--- httpcomponents/httpcore/branches/4.2.x/httpcore/src/main/java/org/apache/http/concurrent/BasicFuture.java (original)
+++ httpcomponents/httpcore/branches/4.2.x/httpcore/src/main/java/org/apache/http/concurrent/BasicFuture.java Fri Jan 18 14:10:51 2013
@@ -99,7 +99,7 @@ public class BasicFuture<T> implements F
         }
     }
 
-    public synchronized boolean completed(final T result) {
+    public boolean completed(final T result) {
         synchronized(this) {
             if (this.completed) {
                 return false;
@@ -114,7 +114,7 @@ public class BasicFuture<T> implements F
         return true;
     }
 
-    public synchronized boolean failed(final Exception exception) {
+    public boolean failed(final Exception exception) {
         synchronized(this) {
             if (this.completed) {
                 return false;
@@ -129,7 +129,7 @@ public class BasicFuture<T> implements F
         return true;
     }
 
-    public synchronized boolean cancel(boolean mayInterruptIfRunning) {
+    public boolean cancel(boolean mayInterruptIfRunning) {
         synchronized(this) {
             if (this.completed) {
                 return false;