You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "lucasbru (via GitHub)" <gi...@apache.org> on 2023/12/04 16:06:18 UTC
[PR] MINOR: Enable auto-tick in AsyncKafkaConsumerTest [kafka]
lucasbru opened a new pull request, #14915:
URL: https://github.com/apache/kafka/pull/14915
AsyncKafkaConsumerTest may run the consumer forever because it relies on timeouts to close correctly, and time is set up to not progress on its own. We enable time auto-tick here to make sure that the consumer can always be closed.
It seems this has caused OOM errors, because we are using many Mockito spies in this code, and Mockito accumulates a lot of memory when running for a long time.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Enable auto-tick in AsyncKafkaConsumerTest [kafka]
Posted by "lucasbru (via GitHub)" <gi...@apache.org>.
lucasbru commented on code in PR #14915:
URL: https://github.com/apache/kafka/pull/14915#discussion_r1414132224
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##########
@@ -81,7 +81,7 @@ public void setUp() {
}
private void setUp(Optional<ConsumerTestBuilder.GroupInformation> groupInfo) {
- testBuilder = new ConsumerTestBuilder(groupInfo);
+ testBuilder = new ConsumerTestBuilder(groupInfo, true, false);
Review Comment:
HeartbeatRequestManager tests rely on autoticks being disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Enable auto-tick in AsyncKafkaConsumerTest [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac merged PR #14915:
URL: https://github.com/apache/kafka/pull/14915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org