You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Jakob Homan (Created) (JIRA)" <ji...@apache.org> on 2012/01/10 22:09:39 UTC

[jira] [Created] (HIVE-2705) SemanticAnalyzer twice swallows an exception it shouldn't

SemanticAnalyzer twice swallows an exception it shouldn't
---------------------------------------------------------

                 Key: HIVE-2705
                 URL: https://issues.apache.org/jira/browse/HIVE-2705
             Project: Hive
          Issue Type: Bug
          Components: Query Processor
    Affects Versions: 0.7.1
            Reporter: Jakob Homan
            Assignee: Jakob Homan
             Fix For: 0.8.1


Twice SemanticAnalyzer catches an exception and drops it, just passing on the original message's in a new SemanticException. This means that those that see the message in the output cannot tell what generated the original exception.  These original exceptions should be wrapped, as they are in other parts of the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2705) SemanticAnalyzer twice swallows an exception it shouldn't

Posted by "Jakob Homan (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jakob Homan updated HIVE-2705:
------------------------------

    Status: Patch Available  (was: Open)
    
> SemanticAnalyzer twice swallows an exception it shouldn't
> ---------------------------------------------------------
>
>                 Key: HIVE-2705
>                 URL: https://issues.apache.org/jira/browse/HIVE-2705
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.7.1
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>             Fix For: 0.8.1
>
>         Attachments: HIVE-2705.patch
>
>
> Twice SemanticAnalyzer catches an exception and drops it, just passing on the original message's in a new SemanticException. This means that those that see the message in the output cannot tell what generated the original exception.  These original exceptions should be wrapped, as they are in other parts of the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2705) SemanticAnalyzer twice swallows an exception it shouldn't

Posted by "Ashutosh Chauhan (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashutosh Chauhan updated HIVE-2705:
-----------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 0.8.1)
                   0.9.0
           Status: Resolved  (was: Patch Available)

Committed to trunk. Thanks, Jakob!
                
> SemanticAnalyzer twice swallows an exception it shouldn't
> ---------------------------------------------------------
>
>                 Key: HIVE-2705
>                 URL: https://issues.apache.org/jira/browse/HIVE-2705
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.7.1
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>             Fix For: 0.9.0
>
>         Attachments: HIVE-2705.patch
>
>
> Twice SemanticAnalyzer catches an exception and drops it, just passing on the original message's in a new SemanticException. This means that those that see the message in the output cannot tell what generated the original exception.  These original exceptions should be wrapped, as they are in other parts of the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2705) SemanticAnalyzer twice swallows an exception it shouldn't

Posted by "Ashutosh Chauhan (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183852#comment-13183852 ] 

Ashutosh Chauhan commented on HIVE-2705:
----------------------------------------

+1 Running tests.
                
> SemanticAnalyzer twice swallows an exception it shouldn't
> ---------------------------------------------------------
>
>                 Key: HIVE-2705
>                 URL: https://issues.apache.org/jira/browse/HIVE-2705
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.7.1
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>             Fix For: 0.8.1
>
>         Attachments: HIVE-2705.patch
>
>
> Twice SemanticAnalyzer catches an exception and drops it, just passing on the original message's in a new SemanticException. This means that those that see the message in the output cannot tell what generated the original exception.  These original exceptions should be wrapped, as they are in other parts of the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2705) SemanticAnalyzer twice swallows an exception it shouldn't

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184348#comment-13184348 ] 

Hudson commented on HIVE-2705:
------------------------------

Integrated in Hive-trunk-h0.21 #1193 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1193/])
    HIVE-2705: SemanticAnalyzer twice swallows an exception it shouldn't (jghoman via hashutosh)

hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1230091
Files : 
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java

                
> SemanticAnalyzer twice swallows an exception it shouldn't
> ---------------------------------------------------------
>
>                 Key: HIVE-2705
>                 URL: https://issues.apache.org/jira/browse/HIVE-2705
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.7.1
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>             Fix For: 0.9.0
>
>         Attachments: HIVE-2705.patch
>
>
> Twice SemanticAnalyzer catches an exception and drops it, just passing on the original message's in a new SemanticException. This means that those that see the message in the output cannot tell what generated the original exception.  These original exceptions should be wrapped, as they are in other parts of the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2705) SemanticAnalyzer twice swallows an exception it shouldn't

Posted by "Jakob Homan (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jakob Homan updated HIVE-2705:
------------------------------

    Attachment: HIVE-2705.patch

Simple patch fixes the two instances of this I found in SemanticAnalyzer.  I'm not wild about taking the message and making it the new exception's message, rather than just completely wrapping the original, but this is consistent with other uses in the file.  This is a simple change, so I've not included tests, but did verify the new code while debugging a separate issue.
                
> SemanticAnalyzer twice swallows an exception it shouldn't
> ---------------------------------------------------------
>
>                 Key: HIVE-2705
>                 URL: https://issues.apache.org/jira/browse/HIVE-2705
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.7.1
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>             Fix For: 0.8.1
>
>         Attachments: HIVE-2705.patch
>
>
> Twice SemanticAnalyzer catches an exception and drops it, just passing on the original message's in a new SemanticException. This means that those that see the message in the output cannot tell what generated the original exception.  These original exceptions should be wrapped, as they are in other parts of the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2705) SemanticAnalyzer twice swallows an exception it shouldn't

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187021#comment-13187021 ] 

Hudson commented on HIVE-2705:
------------------------------

Integrated in Hive-trunk-h0.21-dbg #5 (See [https://builds.apache.org/job/Hive-trunk-h0.21-dbg/5/])
    HIVE-2705: SemanticAnalyzer twice swallows an exception it shouldn't (jghoman via hashutosh)

hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1230091
Files : 
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java

                
> SemanticAnalyzer twice swallows an exception it shouldn't
> ---------------------------------------------------------
>
>                 Key: HIVE-2705
>                 URL: https://issues.apache.org/jira/browse/HIVE-2705
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.7.1
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>             Fix For: 0.9.0
>
>         Attachments: HIVE-2705.patch
>
>
> Twice SemanticAnalyzer catches an exception and drops it, just passing on the original message's in a new SemanticException. This means that those that see the message in the output cannot tell what generated the original exception.  These original exceptions should be wrapped, as they are in other parts of the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira