You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/27 10:59:28 UTC
[GitHub] [apisix-dashboard] okaybase opened a new pull request #2006: chore: add validate trigger and correct tip message for limit-count
okaybase opened a new pull request #2006:
URL: https://github.com/apache/apisix-dashboard/pull/2006
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
add validate trigger and correct tip message for limit-count
- [x] Bugfix
- [ ] New feature provided
- [x] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
Please update this section with detailed description.
**Related issues**
fix/resolve
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [x] Have you modified the corresponding document?
- [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2006: chore: add validate trigger and correct tip message for limit-count plugin
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2006:
URL: https://github.com/apache/apisix-dashboard/pull/2006#issuecomment-887416314
βοΈ Deploy Preview for *apisix-dashboard* ready!
π¨ Explore the source changes: d062dc4abd2c3cab095fe44f6ca992209374c10d
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60ffe7032f817f00085b88a2](https://app.netlify.com/sites/apisix-dashboard/deploys/60ffe7032f817f00085b88a2?utm_source=github&utm_campaign=bot_dl)
π Browse the preview: [https://deploy-preview-2006--apisix-dashboard.netlify.app/](https://deploy-preview-2006--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #2006: chore: add validate trigger and correct tip message for limit-count plugin
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #2006:
URL: https://github.com/apache/apisix-dashboard/pull/2006#issuecomment-891502058
cc @LiteSun @guoqqqi to have a review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #2006: chore: add validate trigger and correct tip message for limit-count plugin
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #2006:
URL: https://github.com/apache/apisix-dashboard/pull/2006#discussion_r679889837
##########
File path: web/cypress/integration/consumer/create-consumer-with-limit-count-plugin-form.spec.js
##########
@@ -46,7 +46,9 @@ context('Create and delete consumer with limit-count plugin form', () => {
consumerName: 'test_consumer',
description: 'desc_by_autotest',
createConsumerSuccess: 'Create Consumer Successfully',
- deleteConsumerSuccess: 'Delete Consumer Successfully'
+ deleteConsumerSuccess: 'Delete Consumer Successfully',
+ redisClusterName: 'Please Enter redis_cluster_name',
+ redisClusterNode: 'Please Enter redis_cluster_node',
Review comment:
```suggestion
redisClusterNode: 'Please Enter node for Redis Cluster',
```
##########
File path: web/cypress/integration/consumer/create-consumer-with-limit-count-plugin-form.spec.js
##########
@@ -46,7 +46,9 @@ context('Create and delete consumer with limit-count plugin form', () => {
consumerName: 'test_consumer',
description: 'desc_by_autotest',
createConsumerSuccess: 'Create Consumer Successfully',
- deleteConsumerSuccess: 'Delete Consumer Successfully'
+ deleteConsumerSuccess: 'Delete Consumer Successfully',
+ redisClusterName: 'Please Enter redis_cluster_name',
Review comment:
```suggestion
redisClusterName: 'Please Enter name of Redis Cluster',
```
##########
File path: web/cypress/integration/route/create-route-with-limit-count-plugin-form.spec.js
##########
@@ -51,6 +51,8 @@ context('Create and delete route with limit-count form', () => {
submitSuccess: 'Submit Successfully',
port: '80',
weight: 1,
+ redisClusterName: 'Please Enter redis_cluster_name',
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2006: chore: add validate trigger and correct tip message for limit-count plugin
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2006:
URL: https://github.com/apache/apisix-dashboard/pull/2006#issuecomment-887416314
π· Deploy Preview for *apisix-dashboard* processing.
π¨ Explore the source changes: 6f55441c317b1ba73b7d176e35aa37928142bd71
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/6103d3440db2740008772eee](https://app.netlify.com/sites/apisix-dashboard/deploys/6103d3440db2740008772eee?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #2006: chore: add validate trigger and correct tip message for limit-count plugin
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #2006:
URL: https://github.com/apache/apisix-dashboard/pull/2006#issuecomment-888748822
Nice improve for UE~!
@okaybase would you please add corresponding test case for your feature?
That will help us merge your pr smoothly, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] okaybase commented on pull request #2006: chore: add validate trigger and correct tip message for limit-count plugin
Posted by GitBox <gi...@apache.org>.
okaybase commented on pull request #2006:
URL: https://github.com/apache/apisix-dashboard/pull/2006#issuecomment-889885551
> Nice improve for UE~!
>
> @okaybase would you please add corresponding test case for your feature?
>
> That will help us merge your pr smoothly, thanks
the test cases added.
thanks for your review~ @liuxiran @juzhiyuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #2006: chore: add validate trigger and correct tip message for limit-count plugin
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #2006:
URL: https://github.com/apache/apisix-dashboard/pull/2006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #2006: chore: add validate trigger and correct tip message for limit-count
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #2006:
URL: https://github.com/apache/apisix-dashboard/pull/2006#issuecomment-887416314
π· Deploy Preview for *apisix-dashboard* processing.
π¨ Explore the source changes: d062dc4abd2c3cab095fe44f6ca992209374c10d
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60ffe7032f817f00085b88a2](https://app.netlify.com/sites/apisix-dashboard/deploys/60ffe7032f817f00085b88a2?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2006: chore: add validate trigger and correct tip message for limit-count plugin
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2006:
URL: https://github.com/apache/apisix-dashboard/pull/2006#issuecomment-887416314
βοΈ Deploy Preview for *apisix-dashboard* ready!
π¨ Explore the source changes: 6f55441c317b1ba73b7d176e35aa37928142bd71
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/6103d3440db2740008772eee](https://app.netlify.com/sites/apisix-dashboard/deploys/6103d3440db2740008772eee?utm_source=github&utm_campaign=bot_dl)
π Browse the preview: [https://deploy-preview-2006--apisix-dashboard.netlify.app/](https://deploy-preview-2006--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] okaybase commented on a change in pull request #2006: chore: add validate trigger and correct tip message for limit-count plugin
Posted by GitBox <gi...@apache.org>.
okaybase commented on a change in pull request #2006:
URL: https://github.com/apache/apisix-dashboard/pull/2006#discussion_r679928336
##########
File path: web/cypress/integration/consumer/create-consumer-with-limit-count-plugin-form.spec.js
##########
@@ -46,7 +46,9 @@ context('Create and delete consumer with limit-count plugin form', () => {
consumerName: 'test_consumer',
description: 'desc_by_autotest',
createConsumerSuccess: 'Create Consumer Successfully',
- deleteConsumerSuccess: 'Delete Consumer Successfully'
+ deleteConsumerSuccess: 'Delete Consumer Successfully',
+ redisClusterName: 'Please Enter redis_cluster_name',
Review comment:
i can understand your suggestion, and thanks for your review.
Only the test contents need consistent with the required tips contents, and the style of all the tips contents for the plugin is like this(redis_cluster_name).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2006: chore: add validate trigger and correct tip message for limit-count plugin
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2006:
URL: https://github.com/apache/apisix-dashboard/pull/2006#issuecomment-887427896
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2006?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2006](https://codecov.io/gh/apache/apisix-dashboard/pull/2006?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (696fba1) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/33c735ec314a82d5c8d67e8fb61ea5e8450ff9ce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33c735e) will **decrease** coverage by `0.34%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 696fba1 differs from pull request most recent head d062dc4. Consider uploading reports for the commit d062dc4 to get more accurate results
[](https://codecov.io/gh/apache/apisix-dashboard/pull/2006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2006 +/- ##
==========================================
- Coverage 64.35% 64.01% -0.35%
==========================================
Files 182 122 -60
Lines 6972 3154 -3818
Branches 753 753
==========================================
- Hits 4487 2019 -2468
+ Misses 2202 1135 -1067
+ Partials 283 0 -283
```
| Flag | Coverage Ξ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `64.01% <ΓΈ> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [web/src/components/Plugin/UI/limit-count.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1jb3VudC50c3g=) | `83.33% <ΓΈ> (ΓΈ)` | |
| [api/internal/core/migrate/dataset.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9kYXRhc2V0Lmdv) | | |
| [api/cmd/status.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9zdGF0dXMuZ28=) | | |
| [api/internal/handler/schema/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3BsdWdpbi5nbw==) | | |
| [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | | |
| [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | | |
| [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | | |
| [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | | |
| [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | | |
| [...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv) | | |
| ... and [52 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2006/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2006?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2006?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33c735e...d062dc4](https://codecov.io/gh/apache/apisix-dashboard/pull/2006?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #2006: chore: add validate trigger and correct tip message for limit-count plugin
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #2006:
URL: https://github.com/apache/apisix-dashboard/pull/2006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org