You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/11/03 16:06:13 UTC
Review Request 39904: local variable 'out' referenced before
assignment
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39904/
-----------------------------------------------------------
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-13697
https://issues.apache.org/jira/browse/AMBARI-13697
Repository: ambari
Description
-------
stderr:
Traceback (most recent call last):
File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-
START/scripts/hook.py", line 38, in <module>
BeforeConfigureHook().execute()
File "/usr/lib/python2.6/site-
packages/resource_management/libraries/script/script.py", line 95, in execute
method(env)
File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-
START/scripts/hook.py", line 33, in hook
setup_hadoop()
File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-
START/scripts/shared_initialization.py", line 76, in setup_hadoop
action = "restart")
File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line
148, in __init__
self.env.run()
File "/usr/lib/python2.6/site-
packages/resource_management/core/environment.py", line 149, in run
self.run_action(resource, action)
File "/usr/lib/python2.6/site-
packages/resource_management/core/environment.py", line 115, in run_action
provider_action()
File "/usr/lib/python2.6/site-
packages/resource_management/core/providers/service.py", line 42, in
action_restart
self._exec_cmd("start", 0)
File "/usr/lib/python2.6/site-
packages/resource_management/core/providers/service.py", line 74, in _exec_cmd
self, command, self.resource.service_name, ret, out))
UnboundLocalError: local variable 'out' referenced before assignment
Diffs
-----
ambari-common/src/main/python/resource_management/core/providers/service.py 50167f1
Diff: https://reviews.apache.org/r/39904/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 39904: local variable 'out' referenced before
assignment
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39904/#review104928
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 3, 2015, 5:06 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39904/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 5:06 p.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-13697
> https://issues.apache.org/jira/browse/AMBARI-13697
>
>
> Repository: ambari
>
>
> Description
> -------
>
> stderr:
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-
> START/scripts/hook.py", line 38, in <module>
> BeforeConfigureHook().execute()
> File "/usr/lib/python2.6/site-
> packages/resource_management/libraries/script/script.py", line 95, in execute
> method(env)
> File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-
> START/scripts/hook.py", line 33, in hook
> setup_hadoop()
> File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-
> START/scripts/shared_initialization.py", line 76, in setup_hadoop
> action = "restart")
> File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line
> 148, in __init__
> self.env.run()
> File "/usr/lib/python2.6/site-
> packages/resource_management/core/environment.py", line 149, in run
> self.run_action(resource, action)
> File "/usr/lib/python2.6/site-
> packages/resource_management/core/environment.py", line 115, in run_action
> provider_action()
> File "/usr/lib/python2.6/site-
> packages/resource_management/core/providers/service.py", line 42, in
> action_restart
> self._exec_cmd("start", 0)
> File "/usr/lib/python2.6/site-
> packages/resource_management/core/providers/service.py", line 74, in _exec_cmd
> self, command, self.resource.service_name, ret, out))
> UnboundLocalError: local variable 'out' referenced before assignment
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/core/providers/service.py 50167f1
>
> Diff: https://reviews.apache.org/r/39904/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>