[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6442: Possibility to choose the initial IP address on a isolated network or VPC

["DaanHoogland (via GitHub)" <gi...@apache.org>]

DaanHoogland commented on code in PR #6442:
URL: https://github.com/apache/cloudstack/pull/6442#discussion_r1084197675


##########
engine/schema/src/main/java/com/cloud/offerings/NetworkOfferingVO.java:
##########
@@ -165,6 +165,17 @@ public String getDisplayText() {
     @Column(name="service_package_id")
     String servicePackageUuid = null;
 
+    @Column(name = "select_snat_address_allowed")

Review Comment:
   this would be extra work and this functionality is rather generic. It is not so that we want to allow this with one network plugin and not with the other.
   So unless there is a good argument against it, I would like to keep it as is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org