Re: [PR] IGNITE-21382 Fixed flaky ItPrimaryReplicaChoiceTest.testPrimaryChangeLongHandling [ignite-3]

["vldpyatkov (via GitHub)" <gi...@apache.org>]

vldpyatkov commented on code in PR #3495:
URL: https://github.com/apache/ignite-3/pull/3495#discussion_r1556247888


##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/LeaseUpdater.java:
##########
@@ -388,10 +397,14 @@ private void updateLeaseBatchInternal() {
                     // so we must start a negotiation round from the beginning; the same we do for the groups that don't have
                     // leaseholders at all.
                     if (isLeaseOutdated(lease)) {
-                        // New lease is granting.
-                        writeNewLease(grpId, lease, candidate, renewedLeases, toBeNegotiated);
+                        // New lease is granted.
+                        writeNewLease(grpId, candidate, renewedLeases);
+
+                        boolean force = !lease.isProlongable() && lease.proposedCandidate() != null;
+
+                        toBeNegotiated.put(grpId, force);

Review Comment:
   Here and above, we have to calculate the force flag and add it to colletion {@code toBeNegotiated}. I think these calls should be joined in one method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org