You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/01/13 11:11:28 UTC

[GitHub] [dubbo-samples] daimingbao opened a new pull request #258: improve dubbo-samples-switch-serialization-thread case

daimingbao opened a new pull request #258:
URL: https://github.com/apache/dubbo-samples/pull/258


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-samples] kylixs commented on a change in pull request #258: improve dubbo-samples-switch-serialization-thread case

Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #258:
URL: https://github.com/apache/dubbo-samples/pull/258#discussion_r557270850



##########
File path: dubbo-samples-switch-serialization-thread/pom.xml
##########
@@ -31,161 +31,70 @@
         <dubbo.version>2.7.7</dubbo.version>
         <spring.version>4.3.16.RELEASE</spring.version>
         <junit.version>4.12</junit.version>
-        <docker-maven-plugin.version>0.30.0</docker-maven-plugin.version>
-        <jib-maven-plugin.version>1.2.0</jib-maven-plugin.version>
         <maven-compiler-plugin.version>3.7.0</maven-compiler-plugin.version>

Review comment:
       maven-compiler-plugin.version  这个属性没必要,直接指定版本号就行




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-samples] chickenlj merged pull request #258: improve dubbo-samples-switch-serialization-thread case

Posted by GitBox <gi...@apache.org>.
chickenlj merged pull request #258:
URL: https://github.com/apache/dubbo-samples/pull/258


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org