[GitHub] [drill] paul-rogers commented on a change in pull request #1868: DRILL-7377: Nested schemas for dynamic EVF columns

[GitBox <gi...@apache.org>]

paul-rogers commented on a change in pull request #1868: DRILL-7377: Nested schemas for dynamic EVF columns
URL: https://github.com/apache/drill/pull/1868#discussion_r332299997
 
 

 ##########
 File path: exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/writer/AbstractTupleWriter.java
 ##########
 @@ -143,6 +144,8 @@ public void dump(HierarchicalFormatter format) {
     ObjectWriter addColumn(TupleWriter tuple, MaterializedField field);
   }
 
+  protected static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(AbstractTupleWriter.class);
 
 Review comment:
   Done. But note that, when the code was converted from Logback to slf4j, all of the files ended up with the fully qualified class names. Perhaps someone should write a script to change all of these if we wish to use qualified names.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services