You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ma...@apache.org on 2024/12/05 23:27:09 UTC

(superset) 07/07: touchups

This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch sqla-close
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 88b76df1cf3d415fd7879169b8bf221a7556d454
Author: Maxime Beauchemin <ma...@gmail.com>
AuthorDate: Thu Dec 5 15:26:22 2024 -0800

    touchups
---
 superset/config.py                   | 1 +
 superset/sqllab/sql_json_executer.py | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/config.py b/superset/config.py
index 9ed61ad3d1..c5d3199873 100644
--- a/superset/config.py
+++ b/superset/config.py
@@ -207,6 +207,7 @@ SQLALCHEMY_DATABASE_URI = (
 # for example, if you don't want to use a connection pool, uncomment those next 2 lines
 # from sqlalchemy.pool import NullPool
 # SQLALCHEMY_ENGINE_OPTIONS = {"poolclass": NullPool}
+SQLALCHEMY_ENGINE_OPTIONS = {}
 
 
 # In order to hook up a custom password store for all SQLALCHEMY connections
diff --git a/superset/sqllab/sql_json_executer.py b/superset/sqllab/sql_json_executer.py
index 0c21410fe0..02396fb75d 100644
--- a/superset/sqllab/sql_json_executer.py
+++ b/superset/sqllab/sql_json_executer.py
@@ -102,7 +102,6 @@ class SynchronousSqlJsonExecutor(SqlJsonExecutorBase):
             raise
         except Exception as ex:
             logger.exception("Query %i failed unexpectedly", query_id)
-            logger.error(ex)
             raise SupersetGenericDBErrorException(
                 utils.error_msg_from_exception(ex)
             ) from ex