You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/11/15 22:57:17 UTC
[kudu-CR] [tests] don't use client-stress-test in ASAN/TSAN builds
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18027
Change subject: [tests] don't use client-stress-test in ASAN/TSAN builds
......................................................................
[tests] don't use client-stress-test in ASAN/TSAN builds
Test scenarios in client-stress-test are CPU and memory intensive,
and some of those are intended for benchmarking to track performance
regressions in the C++ client's metacache. With that, there isn't much
sense to build and run them for ASAN/TSAN builds, so why to compile them
under ASAN/TSAN configurations at all? As for the test coverage to catch
possible concurrency and undefined behavior issues, there is overlap
between the tests in client-stress-test and tests in client-test,
master-stress-test, and many others.
The motivation for this change is to address the feedback for one
of prior changelists [1].
[1] https://gerrit.cloudera.org/#/c/18024/3/src/kudu/integration-tests/client-stress-test.cc@337
Change-Id: Ic044d051d6011d1cca95fc92d1daf400e3e3d116
---
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/integration-tests/client-stress-test.cc
2 files changed, 6 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/18027/1
--
To view, visit http://gerrit.cloudera.org:8080/18027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic044d051d6011d1cca95fc92d1daf400e3e3d116
Gerrit-Change-Number: 18027
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [tests] don't build client-stress-test with ASAN/TSAN
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18027 )
Change subject: [tests] don't build client-stress-test with ASAN/TSAN
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic044d051d6011d1cca95fc92d1daf400e3e3d116
Gerrit-Change-Number: 18027
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 31 Jan 2022 08:53:23 +0000
Gerrit-HasComments: No
[kudu-CR] [tests] don't use client-stress-test in ASAN/TSAN builds
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18027 )
Change subject: [tests] don't use client-stress-test in ASAN/TSAN builds
......................................................................
Patch Set 1: Verified+1
unrelated dist-test failure (RELEASE build configuration):
15:11:16 INFO:dist_test.client:Failed to contact server, will retry in 5 seconds (attempt 2 of 10)
15:11:16 INFO:dist_test.client:Last exception is: HTTP Error 500: Internal Server Error
--
To view, visit http://gerrit.cloudera.org:8080/18027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic044d051d6011d1cca95fc92d1daf400e3e3d116
Gerrit-Change-Number: 18027
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 16 Nov 2021 03:16:11 +0000
Gerrit-HasComments: No
[kudu-CR] [tests] don't use client-stress-test in ASAN/TSAN builds
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18027 )
Change subject: [tests] don't use client-stress-test in ASAN/TSAN builds
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic044d051d6011d1cca95fc92d1daf400e3e3d116
Gerrit-Change-Number: 18027
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 16 Nov 2021 08:02:09 +0000
Gerrit-HasComments: No
[kudu-CR] [tests] don't use client-stress-test in ASAN/TSAN builds
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18027 )
Change subject: [tests] don't use client-stress-test in ASAN/TSAN builds
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18027/1/src/kudu/integration-tests/CMakeLists.txt
File src/kudu/integration-tests/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/18027/1/src/kudu/integration-tests/CMakeLists.txt@150
PS1, Line 150: # Some stress tests are not build under ASAN/TSAN.
nit: maybe instead mention that this should only used for benchmarks or stress tests that have test coverage elsewhere?
--
To view, visit http://gerrit.cloudera.org:8080/18027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic044d051d6011d1cca95fc92d1daf400e3e3d116
Gerrit-Change-Number: 18027
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 16 Nov 2021 19:23:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tests] don't build client-stress-test with ASAN/TSAN
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Andrew Wong, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18027
to look at the new patch set (#2).
Change subject: [tests] don't build client-stress-test with ASAN/TSAN
......................................................................
[tests] don't build client-stress-test with ASAN/TSAN
Test scenarios in client-stress-test are CPU and memory intensive,
and some of those are intended for benchmarking to track performance
regressions in the C++ client's metacache. With that, there isn't much
sense to build and run them for ASAN/TSAN builds, so why to compile them
under ASAN/TSAN configurations at all? As for the test coverage to catch
possible concurrency and undefined behavior issues, there is overlap
between the tests in client-stress-test and tests in client-test,
master-stress-test, and many others.
The motivation for this change is to address the feedback for one
of prior changelists [1].
[1] https://gerrit.cloudera.org/#/c/18024/3/src/kudu/integration-tests/client-stress-test.cc@337
Change-Id: Ic044d051d6011d1cca95fc92d1daf400e3e3d116
---
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/integration-tests/client-stress-test.cc
2 files changed, 12 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/18027/2
--
To view, visit http://gerrit.cloudera.org:8080/18027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic044d051d6011d1cca95fc92d1daf400e3e3d116
Gerrit-Change-Number: 18027
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [tests] don't build client-stress-test with ASAN/TSAN
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18027 )
Change subject: [tests] don't build client-stress-test with ASAN/TSAN
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18027/1/src/kudu/integration-tests/CMakeLists.txt
File src/kudu/integration-tests/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/18027/1/src/kudu/integration-tests/CMakeLists.txt@150
PS1, Line 150: # Some stress tests are not build under ASAN/TSAN.
> nit: maybe instead mention that this should only used for benchmarks or str
Done
--
To view, visit http://gerrit.cloudera.org:8080/18027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic044d051d6011d1cca95fc92d1daf400e3e3d116
Gerrit-Change-Number: 18027
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 31 Jan 2022 03:23:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tests] don't use client-stress-test in ASAN/TSAN builds
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [tests] don't use client-stress-test in ASAN/TSAN builds
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic044d051d6011d1cca95fc92d1daf400e3e3d116
Gerrit-Change-Number: 18027
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [tests] don't build client-stress-test with ASAN/TSAN
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18027 )
Change subject: [tests] don't build client-stress-test with ASAN/TSAN
......................................................................
Patch Set 2: Verified+1
unrelated test failure in CatalogManagerTskITest.LeadershipChangeOnTskGeneration
--
To view, visit http://gerrit.cloudera.org:8080/18027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic044d051d6011d1cca95fc92d1daf400e3e3d116
Gerrit-Change-Number: 18027
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 31 Jan 2022 04:15:25 +0000
Gerrit-HasComments: No
[kudu-CR] [tests] don't build client-stress-test with ASAN/TSAN
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [tests] don't build client-stress-test with ASAN/TSAN
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic044d051d6011d1cca95fc92d1daf400e3e3d116
Gerrit-Change-Number: 18027
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [tests] don't build client-stress-test with ASAN/TSAN
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18027 )
Change subject: [tests] don't build client-stress-test with ASAN/TSAN
......................................................................
[tests] don't build client-stress-test with ASAN/TSAN
Test scenarios in client-stress-test are CPU and memory intensive,
and some of those are intended for benchmarking to track performance
regressions in the C++ client's metacache. With that, there isn't much
sense to build and run them for ASAN/TSAN builds, so why to compile them
under ASAN/TSAN configurations at all? As for the test coverage to catch
possible concurrency and undefined behavior issues, there is overlap
between the tests in client-stress-test and tests in client-test,
master-stress-test, and many others.
The motivation for this change is to address the feedback for one
of prior changelists [1].
[1] https://gerrit.cloudera.org/#/c/18024/3/src/kudu/integration-tests/client-stress-test.cc@337
Change-Id: Ic044d051d6011d1cca95fc92d1daf400e3e3d116
Reviewed-on: http://gerrit.cloudera.org:8080/18027
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/integration-tests/client-stress-test.cc
2 files changed, 12 insertions(+), 15 deletions(-)
Approvals:
Alexey Serbin: Verified
Attila Bukor: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic044d051d6011d1cca95fc92d1daf400e3e3d116
Gerrit-Change-Number: 18027
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)