[GitHub] [cordova-plugin-geolocation] breautek commented on a change in pull request #181: Add missing information [IOS]

[GitBox <gi...@apache.org>]

breautek commented on a change in pull request #181: Add missing information [IOS]
URL: https://github.com/apache/cordova-plugin-geolocation/pull/181#discussion_r346638615
 
 

 ##########
 File path: README.md
 ##########
 @@ -160,15 +160,27 @@ error, the `geolocationError` callback is passed a
 
  This plugins requires the following usage description:
 
- * `NSLocationWhenInUseUsageDescription` describes the reason that the app accesses the user's location. 
+ * `NSLocationWhenInUseUsageDescription` describes the reason that the app accesses the user's location, this used while the app is running in the foreground.
+ * `NSLocationAlwaysAndWhenInUseUsageDescription` describes the reason that the app is requesting access to the user’s location information at all times, use this key if your iOS app accesses location information while running in the background and foreground. 
+ * `NSLocationAlwaysUsageDescription` describes the reason that the app is requesting access to the user's location at all times, use this key if your iOS app accesses location information in the background, and you deploy to a target earlier than iOS 11. In that case, add both this key and `NSLocationAlwaysAndWhenInUseUsageDescription` to your app’s `Info.plist` file with the same message.
 
 Review comment:
   ```suggestion
    * `NSLocationAlwaysUsageDescription` describes the reason that the app is requesting access to the user's location at all times. Use this key if your iOS app accesses location information in the background. and you deploy to a target earlier than iOS 11. In that case, add both this key and `NSLocationAlwaysAndWhenInUseUsageDescription` to your app’s `Info.plist` file with the same message.
   ```
   
   > In that case, add both this key and `NSLocationAlwaysAndWhenInUseUsageDescription` to your app’s `Info.plist` file with the same message.
   
   Can you clarify this? Are we suppose to use `NSLocationAlwaysAndWhenInUseUsageDescription` on iOS >= 12?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org