[GitHub] [hive] kasakrisz commented on a change in pull request #2887: HIVE-25816: Log CBO plan after rule application for debugging purposes

[GitBox <gi...@apache.org>]

kasakrisz commented on a change in pull request #2887:
URL: https://github.com/apache/hive/pull/2887#discussion_r770684249



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
##########
@@ -2427,7 +2430,7 @@ protected RelNode executeProgram(RelNode basePlan, HepProgram program,
       // Create planner and copy context
       HepPlanner planner = new HepPlanner(program,
           basePlan.getCluster().getPlanner().getContext());
-
+      planner.addListener(new RuleEventLogger());

Review comment:
       Should we add a check the log level setting before adding this listener like
   ```
   if (LOG.isDebugEnabled()) {
     planner.addListener(new RuleEventLogger());
   }
   ```
   It may seems to be a preliminary optimization, what do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org