You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/03/24 19:18:00 UTC
[jira] [Work logged] (BEAM-13918) Increase unit testing coverage in the datastoreio package
[ https://issues.apache.org/jira/browse/BEAM-13918?focusedWorklogId=747399&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-747399 ]
ASF GitHub Bot logged work on BEAM-13918:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Mar/22 19:17
Start Date: 24/Mar/22 19:17
Worklog Time Spent: 10m
Work Description: codecov[bot] commented on pull request #17173:
URL: https://github.com/apache/beam/pull/17173#issuecomment-1077979627
# [Codecov](https://codecov.io/gh/apache/beam/pull/17173?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17173](https://codecov.io/gh/apache/beam/pull/17173?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2ffbbc4) into [master](https://codecov.io/gh/apache/beam/commit/993061af4113f8324bd034b865cb3ca513a0b9aa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (993061a) will **increase** coverage by `0.07%`.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## master #17173 +/- ##
==========================================
+ Coverage 73.96% 74.03% +0.07%
==========================================
Files 672 672
Lines 88259 88260 +1
==========================================
+ Hits 65277 65346 +69
+ Misses 21869 21794 -75
- Partials 1113 1120 +7
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `49.75% <50.00%> (+0.27%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/17173?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/go/pkg/beam/io/datastoreio/datastore.go](https://codecov.io/gh/apache/beam/pull/17173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9pby9kYXRhc3RvcmVpby9kYXRhc3RvcmUuZ28=) | `68.18% <50.00%> (+52.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/17173?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/17173?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [993061a...2ffbbc4](https://codecov.io/gh/apache/beam/pull/17173?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 747399)
Remaining Estimate: 0h
Time Spent: 10m
> Increase unit testing coverage in the datastoreio package
> ---------------------------------------------------------
>
> Key: BEAM-13918
> URL: https://issues.apache.org/jira/browse/BEAM-13918
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Jack McCluskey
> Assignee: Yi Hu
> Priority: P2
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Increase unit testing coverage in the [datastoreio package|https://github.com/apache/beam/tree/release-2.36.0/sdks/go/pkg/beam/io/datastoreio]
> We want code coverage at or above 50%, it is currently at 17.2%.
> This will involve mocking a datastore service.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)