You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datafusion.apache.org by gi...@apache.org on 2026/10/14 09:32:20 UTC

(datafusion) branch gh-readonly-queue/main/pr-26244-59d04672d6c43c334486f12c34aa46adb69a3b30 created (now 51bb156dd7)

This is an automated email from the ASF dual-hosted git repository.

github-merge-queue[bot] pushed a change to branch gh-readonly-queue/main/pr-26244-59d04672d6c43c334486f12c34aa46adb69a3b30
in repository https://gitbox.apache.org/repos/asf/datafusion.git


      at 51bb156dd7 fix: remove duplicate predicate benchmark result (#26244)

This branch includes the following new commits:

     new 51bb156dd7 fix: remove duplicate predicate benchmark result (#26244)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org


(datafusion) 01/01: fix: remove duplicate predicate benchmark result (#26244)

Posted by gi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-26244-59d04672d6c43c334486f12c34aa46adb69a3b30
in repository https://gitbox.apache.org/repos/asf/datafusion.git

commit 51bb156dd7978dc817916dcd74594b880677dfdd
Author: Bruce Ritchie <br...@gmail.com>
AuthorDate: Wed Oct 14 08:50:32 2026 +0000

    fix: remove duplicate predicate benchmark result (#26244)
    
    ## Which issue does this PR close?
    
    No linked issue.
    
    ## Rationale for this change
    
    Running `benchmark_runner predicate_eval --query 1 --iterations 1 --rows
    1000000` fails while parsing the template with `multiple results found`.
    
    ## What changes are included in this PR?
    
    Remove the duplicate `result` directive from
    `predicate_eval.benchmark.template`.
    
    ## What is the testing strategy for this PR?
    
    Using the existing debug benchmark runner, reproduced the parser error
    with the original template and verified the fixed template completes
    query 1 successfully with one result row. `cargo fmt --all` passed.
    
    `cargo clippy --all-targets --all-features -- -D warnings` fails on
    three `mutable_key_type` diagnostics in unchanged
    `datafusion/optimizer/src/push_down_filter.rs` on upstream main. The
    standard `./dev/rust_lint.sh` suite passed. Extended workspace tests are
    still running; they have reached the SQL logic tests after passing the
    preceding Rust test binaries. Test data is supplied from the existing
    checkout via `ARROW_TEST_DATA` and `PARQUET_TEST_DATA`.
    
    ## Are there any user-facing changes?
    
    The predicate evaluation benchmark can run again.
---
 .../sql_benchmarks/predicate_eval/predicate_eval.benchmark.template     | 2 --
 1 file changed, 2 deletions(-)

diff --git a/benchmarks/sql_benchmarks/predicate_eval/predicate_eval.benchmark.template b/benchmarks/sql_benchmarks/predicate_eval/predicate_eval.benchmark.template
index 766bd20270..4a23594d3b 100644
--- a/benchmarks/sql_benchmarks/predicate_eval/predicate_eval.benchmark.template
+++ b/benchmarks/sql_benchmarks/predicate_eval/predicate_eval.benchmark.template
@@ -18,6 +18,4 @@ run sql_benchmarks/predicate_eval/queries/${QUERY}.sql
 
 result sql_benchmarks/predicate_eval/results/${NAME}.csv
 
-result sql_benchmarks/predicate_eval/results/${NAME}.csv
-
 cleanup sql_benchmarks/predicate_eval/init/cleanup.sql


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org