You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Aljoscha Krettek (JIRA)" <ji...@apache.org> on 2015/10/16 10:58:05 UTC

[jira] [Commented] (FLINK-2857) Gelly API improvements

    [ https://issues.apache.org/jira/browse/FLINK-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14960384#comment-14960384 ] 

Aljoscha Krettek commented on FLINK-2857:
-----------------------------------------

+1 Seems to be good :D

> Gelly API improvements
> ----------------------
>
>                 Key: FLINK-2857
>                 URL: https://issues.apache.org/jira/browse/FLINK-2857
>             Project: Flink
>          Issue Type: Improvement
>          Components: Gelly
>            Reporter: Vasia Kalavri
>
> During the Flink Forward Gelly School training, I got some really valuable feedback from participants on what they found hard to grasp or non-intuitive in the API. 
> Based on that, I propose we make the following improvements:
> -  rename the mapper in creation methods to {{VertexInitializer}}, so that its purpose is easier to understand.
> - add a {{fromTuple2DataSet}} method to easily create graphs from {{Tuple2}} datasets, i.e. edges with no values.
> - in {{joinWith*}} methods, it is hard to understand what are the parameters in the mapper and what will be the output. I suggest we flatten them, try to give intuitive names and improve the javadocs.
> - in neighborhood methods, it is hard to understand what are the arguments of the {{EdgeFunction.iterateEdges}} and {{ReduceEdgesFunction.reduceEdges}}. Javadocs and parameter names could be improved here too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)