You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "TakaHiR07 (via GitHub)" <gi...@apache.org> on 2024/11/25 07:37:16 UTC
[PR] [fix][perf] fix performanceConsumer log error throughput [pulsar]
TakaHiR07 opened a new pull request, #23636:
URL: https://github.com/apache/pulsar/pull/23636
### Motivation
fix error throughput log in performanceConsumer. bytes -> Mb no need to *8.
### Modifications
fix error.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][perf] fix performanceConsumer log error throughput [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #23636:
URL: https://github.com/apache/pulsar/pull/23636#issuecomment-2499994192
> Ok. But I think MB is clearer
@TakaHiR07 I agree that it's confusing to use Mbit/s here and MB/s in many other locations.
Network bandwidth is commonly expressed as Mbit/s. Perhaps the reason to use Mbit/s here is to match the unit that is used for network bandwidth.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][perf] fix performanceConsumer log error throughput [pulsar]
Posted by "TakaHiR07 (via GitHub)" <gi...@apache.org>.
TakaHiR07 commented on PR #23636:
URL: https://github.com/apache/pulsar/pull/23636#issuecomment-2499460432
> > fix error throughput log in performanceConsumer. bytes -> Mb no need to *8.
>
> The previous calculation is intentional. The previous unit has been megabits instead of megabytes.
>
> https://github.com/apache/pulsar/blob/002fa49692ff4b8b038bf2edeeb3b32ed218e64f/pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceConsumer.java#L526
Ok. But I think MB is clearer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][perf] fix performanceConsumer log error throughput [pulsar]
Posted by "TakaHiR07 (via GitHub)" <gi...@apache.org>.
TakaHiR07 closed pull request #23636: [fix][perf] fix performanceConsumer log error throughput
URL: https://github.com/apache/pulsar/pull/23636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org