[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29811: [SPARK-32959][SQL][TEST] Fix an invalid test in DataSourceV2SQLSuite

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #29811:
URL: https://github.com/apache/spark/pull/29811#discussion_r492456132



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/connector/TestV2SessionCatalogBase.scala
##########
@@ -47,10 +47,13 @@ private[connector] trait TestV2SessionCatalogBase[T <: Table] extends Delegating
       tables.get(ident)
     } else {
       // Table was created through the built-in catalog
-      val t = super.loadTable(ident)
-      val table = newTable(t.name(), t.schema(), t.partitioning(), t.properties())
-      tables.put(ident, table)
-      table
+      super.loadTable(ident) match {
+        case v1Table: V1Table if v1Table.v1Table.tableType == CatalogTableType.VIEW => v1Table

Review comment:
       @imback82 . This is orthogonal to `Fix an invalid test in DataSourceV2SQLSuite`. Could you make a PR for this one independently?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org