You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/11/14 18:11:49 UTC
[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6146: Build: Enable revapi on core/parquet/orc/common/data modules & fix API breaks
danielcweeks commented on code in PR #6146:
URL: https://github.com/apache/iceberg/pull/6146#discussion_r1021901580
##########
.palantir/revapi.yml:
##########
@@ -1,4 +1,85 @@
acceptedBreaks:
+ "1.0.0":
+ org.apache.iceberg:iceberg-core:
+ - code: "java.class.defaultSerializationChanged"
+ old: "class org.apache.iceberg.BaseMetadataTable"
+ new: "class org.apache.iceberg.BaseMetadataTable"
+ justification: "Serialization changed"
+ - code: "java.class.defaultSerializationChanged"
+ old: "class org.apache.iceberg.BaseTable"
+ new: "class org.apache.iceberg.BaseTable"
+ justification: "Serialization changed"
+ - code: "java.class.defaultSerializationChanged"
+ old: "class org.apache.iceberg.BaseTransaction.TransactionTable"
+ new: "class org.apache.iceberg.BaseTransaction.TransactionTable"
+ justification: "Serialization changed"
+ - code: "java.class.defaultSerializationChanged"
+ old: "class org.apache.iceberg.MetricsConfig"
+ new: "class org.apache.iceberg.MetricsConfig"
+ justification: "Serialization changed"
+ - code: "java.class.defaultSerializationChanged"
+ old: "class org.apache.iceberg.SerializableTable"
+ new: "class org.apache.iceberg.SerializableTable"
+ justification: "Serialization changed"
+ - code: "java.class.defaultSerializationChanged"
+ old: "class org.apache.iceberg.TableMetadata"
+ new: "class org.apache.iceberg.TableMetadata"
+ justification: "Serialization changed"
+ - code: "java.field.noLongerConstant"
+ old: "field org.apache.iceberg.TableProperties.DELETE_MODE_DEFAULT"
+ new: "field org.apache.iceberg.TableProperties.DELETE_MODE_DEFAULT"
+ justification: "Refactorings"
+ - code: "java.field.noLongerConstant"
+ old: "field org.apache.iceberg.TableProperties.MERGE_MODE_DEFAULT"
+ new: "field org.apache.iceberg.TableProperties.MERGE_MODE_DEFAULT"
+ justification: "Refactorings"
+ - code: "java.field.noLongerConstant"
+ old: "field org.apache.iceberg.TableProperties.UPDATE_MODE_DEFAULT"
+ new: "field org.apache.iceberg.TableProperties.UPDATE_MODE_DEFAULT"
+ justification: "Refactorings"
+ - code: "java.method.addedToInterface"
+ new: "method <T extends org.apache.iceberg.rest.RESTResponse> T org.apache.iceberg.rest.RESTClient::delete(java.lang.String,\
+ \ java.util.Map<java.lang.String, java.lang.String>, java.lang.Class<T>, java.util.Map<java.lang.String,\
+ \ java.lang.String>, java.util.function.Consumer<org.apache.iceberg.rest.responses.ErrorResponse>)"
+ justification: "Adding new method where query params can be used"
Review Comment:
I think we should add a check and throw in the event query params are passed to the default implementation. This shouldn't silently drop query params.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org