You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "jinhongyii (via GitHub)" <gi...@apache.org> on 2023/09/12 20:42:15 UTC
[GitHub] [tvm] jinhongyii opened a new pull request, #15735: [Unity][disco] Change collective communication to destination-passing style
jinhongyii opened a new pull request, #15735:
URL: https://github.com/apache/tvm/pull/15735
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao commented on a diff in pull request #15735: [Unity][disco] Change collective communication to destination-passing style
Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao commented on code in PR #15735:
URL: https://github.com/apache/tvm/pull/15735#discussion_r1324747875
##########
tests/python/disco/test_nccl.py:
##########
@@ -93,25 +96,25 @@ def test_scatter():
)
-def test_gather():
- num_workers = 2
- devices = [1, 2]
- array = np.arange(36, dtype="float32")
+# def test_gather():
Review Comment:
While understanding that @jinhongyii's time is limited, we do not usually prefer having code comments in a serious branch. I'm committed to get it fixed as soon as I could (this week) in PR https://github.com/apache/tvm/pull/15727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao merged pull request #15735: [Unity][disco] Change collective communication to destination-passing style
Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao merged PR #15735:
URL: https://github.com/apache/tvm/pull/15735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jinhongyii commented on pull request #15735: [Unity][disco] Change collective communication to destination-passing style
Posted by "jinhongyii (via GitHub)" <gi...@apache.org>.
jinhongyii commented on PR #15735:
URL: https://github.com/apache/tvm/pull/15735#issuecomment-1716402520
cc: @junrushao @tqchen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org