You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/27 09:42:05 UTC

[GitHub] [apisix] liuhengloveyou opened a new pull request #2304: fix: Update error message when Route doesn't exist

liuhengloveyou opened a new pull request #2304:
URL: https://github.com/apache/apisix/pull/2304


   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   Fixes #2302 
   
   It used to be "failed to match any routes", now it's "404 Route Not Found"。
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [x] Is this PR backward compatible?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] liuhengloveyou commented on pull request #2304: fix: Update error message when Route doesn't exist。

Posted by GitBox <gi...@apache.org>.
liuhengloveyou commented on pull request #2304:
URL: https://github.com/apache/apisix/pull/2304#issuecomment-698255684


   PS: 
   whether the error message needs to be prefixed or not, to distinguish between an apisix error and a business error.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] liuhengloveyou commented on pull request #2304: fix: Update error message when Route doesn't exist。

Posted by GitBox <gi...@apache.org>.
liuhengloveyou commented on pull request #2304:
URL: https://github.com/apache/apisix/pull/2304#issuecomment-698666356


   > @liuhengloveyou please check the commit mesg again, contains Chinese chars.
   
   updated


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] moonming commented on pull request #2304: fix: Update error message when Route doesn't exist。

Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #2304:
URL: https://github.com/apache/apisix/pull/2304#issuecomment-698299746






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on pull request #2304: fix: Update error message when Route doesn't exist

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2304:
URL: https://github.com/apache/apisix/pull/2304#issuecomment-703343321


   @liuhengloveyou pls update your branch.
   
   ![image](https://user-images.githubusercontent.com/6814606/95031377-44b7af00-06e8-11eb-88af-3529b207897d.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] liuhengloveyou commented on pull request #2304: fix: Update error message when Route doesn't exist。

Posted by GitBox <gi...@apache.org>.
liuhengloveyou commented on pull request #2304:
URL: https://github.com/apache/apisix/pull/2304#issuecomment-698255684






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] liuhengloveyou commented on pull request #2304: fix: Update error message when Route doesn't exist

Posted by GitBox <gi...@apache.org>.
liuhengloveyou commented on pull request #2304:
URL: https://github.com/apache/apisix/pull/2304#issuecomment-700388458


   > > @liuhengloveyou please update the status
   > 
   > ping @liuhengloveyou
   
   OK


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] liuhengloveyou edited a comment on pull request #2304: fix: Update error message when Route doesn't exist

Posted by GitBox <gi...@apache.org>.
liuhengloveyou edited a comment on pull request #2304:
URL: https://github.com/apache/apisix/pull/2304#issuecomment-698850089


   > > > @liuhengloveyou please check the commit mesg again, contains Chinese chars.
   > > 
   > > 
   > > updated
   > 
   > No, the title of PR still has Chinese char.
   
   Updated again.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on pull request #2304: fix: Update error message when Route doesn't exist

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2304:
URL: https://github.com/apache/apisix/pull/2304#issuecomment-699720635


   > @liuhengloveyou please update the status
   
   ping @liuhengloveyou 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] moonming commented on pull request #2304: fix: Update error message when Route doesn't exist。

Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #2304:
URL: https://github.com/apache/apisix/pull/2304#issuecomment-698778992


   > > @liuhengloveyou please check the commit mesg again, contains Chinese chars.
   > 
   > updated
   
   No, the title of PR still has Chinese char.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] moonming commented on pull request #2304: fix: Update error message when Route doesn't exist

Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #2304:
URL: https://github.com/apache/apisix/pull/2304#issuecomment-699607119


   @liuhengloveyou why close this PR? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on pull request #2304: fix: Update error message when Route doesn't exist

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2304:
URL: https://github.com/apache/apisix/pull/2304#issuecomment-699267454


   @liuhengloveyou please update the status
   
   ![image](https://user-images.githubusercontent.com/6814606/94327297-9cfdfb00-ffdc-11ea-9e8f-e2f09af42384.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] liuhengloveyou edited a comment on pull request #2304: fix: Update error message when Route doesn't exist

Posted by GitBox <gi...@apache.org>.
liuhengloveyou edited a comment on pull request #2304:
URL: https://github.com/apache/apisix/pull/2304#issuecomment-698850089


   > > > @liuhengloveyou please check the commit mesg again, contains Chinese chars.
   > > 
   > > 
   > > updated
   > 
   > No, the title of PR still has Chinese char.
   
   Updated again.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on pull request #2304: "failed to match any routes" to "404 Route Not Found"

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2304:
URL: https://github.com/apache/apisix/pull/2304#issuecomment-698249241


   bad title and commit log style
   
   ![image](https://user-images.githubusercontent.com/6814606/94131640-c447b180-fe90-11ea-9ad4-b850896281ef.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] liuhengloveyou commented on pull request #2304: fix: Update error message when Route doesn't exist

Posted by GitBox <gi...@apache.org>.
liuhengloveyou commented on pull request #2304:
URL: https://github.com/apache/apisix/pull/2304#issuecomment-698850089


   > > > @liuhengloveyou please check the commit mesg again, contains Chinese chars.
   > > 
   > > 
   > > updated
   > 
   > No, the title of PR still has Chinese char.
   
   updated


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] moonming commented on pull request #2304: fix: Update error message when Route doesn't exist。

Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #2304:
URL: https://github.com/apache/apisix/pull/2304#issuecomment-698299746


   @liuhengloveyou please check the commit mesg again, contains Chinese chars.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis merged pull request #2304: fix: Update error message when Route doesn't exist

Posted by GitBox <gi...@apache.org>.
membphis merged pull request #2304:
URL: https://github.com/apache/apisix/pull/2304


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] liuhengloveyou closed pull request #2304: fix: Update error message when Route doesn't exist

Posted by GitBox <gi...@apache.org>.
liuhengloveyou closed pull request #2304:
URL: https://github.com/apache/apisix/pull/2304


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on pull request #2304: "failed to match any routes" to "404 Route Not Found"

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2304:
URL: https://github.com/apache/apisix/pull/2304#issuecomment-698249241


   bad title and commit log style
   
   ![image](https://user-images.githubusercontent.com/6814606/94131640-c447b180-fe90-11ea-9ad4-b850896281ef.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org