[GitHub] reminisce commented on a change in pull request #10417: Error handling for non-positive reps of tile op

[GitBox <gi...@apache.org>]

reminisce commented on a change in pull request #10417: Error handling for non-positive reps of tile op
URL: https://github.com/apache/incubator-mxnet/pull/10417#discussion_r179559986
 
 

 ##########
 File path: tests/python/unittest/test_operator.py
 ##########
 @@ -3521,14 +3521,6 @@ def test_empty_reps():
         b_tiled = mx.nd.tile(b, ()).asnumpy()
         assert same(a_tiled, b_tiled)
 
-    def test_zero_reps():
-        a = np.array([[2, 3, 4], [5, 6, 7]], dtype=np.int32)
-        b = mx.nd.array(a, ctx=default_context(), dtype=a.dtype)
-        reps = (2, 0, 4, 5)
 
 Review comment:
   It would return an empty NDArray with some dim size equal to zero. I was following the NumPy's convention to implement the behavior. Since MXNet does not support empty NDArrays in any way, I think it's okay to move this to `assert_exception` test?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services