[GitHub] [ozone] fapifta commented on pull request #3173: HDDS-6418. Datanode usage info uses wrong version number

[GitBox <gi...@apache.org>]

fapifta commented on pull request #3173:
URL: https://github.com/apache/ozone/pull/3173#issuecomment-1061892014


   In DatanodeDetails, we have. a method called getProtobufMessage, which uses the same toProto(int) call with the ClientVersion.CURRENT_VERSION value (so with the by the datanode known highest client version, instead of the actual client version).
   This getProtobufMessage method is used in the getExtendedProtobufMessage() method, in heartbeat (which is not a problem atm as we do not have rolling upgrade), CreatePipelineCommand, ReplicateContainerCommand, and in the getContainerReplicas call in the SCMClientProtocolServer. We need to validate if these are also called from the client side, and if so, then we need to change the behavior for those as well.
   
   Can we put this on hold if the scope is really this large? Would it be better to address this together with the change to enum, or after that if the problem scope is larger? What do you think @adoroszlai @errose28?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org