You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/10 22:11:22 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #35809: [SPARK-38513][K8S] Move custom scheduler-specific configs to under `spark.kubernetes.scheduler.NAME` prefix
dongjoon-hyun opened a new pull request #35809:
URL: https://github.com/apache/spark/pull/35809
### What changes were proposed in this pull request?
This PR aims to move
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35809: [SPARK-38513][K8S] Move custom scheduler-specific configs to under `spark.kubernetes.scheduler.NAME` prefix
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35809:
URL: https://github.com/apache/spark/pull/35809#issuecomment-1064589198
Could you review this please, @viirya ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on a change in pull request #35809: [SPARK-38513][K8S] Move custom scheduler-specific configs to under `spark.kubernetes.scheduler.NAME` prefix
Posted by GitBox <gi...@apache.org>.
Yikun commented on a change in pull request #35809:
URL: https://github.com/apache/spark/pull/35809#discussion_r824254297
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/VolcanoFeatureStep.scala
##########
@@ -77,3 +70,8 @@ private[spark] class VolcanoFeatureStep extends KubernetesDriverCustomFeatureCon
SparkPod(k8sPod, pod.container)
}
}
+
+private[spark] object VolcanoFeatureStep {
+ val POD_GROUP_ANNOTATION = "scheduling.k8s.io/group-name"
+ val POD_GROUP_TEMPLATE_FILE_KEY = "spark.kubernetes.scheduler.volcano.podGroupTemplateFile"
Review comment:
+1, I'm fine with this, then I just need to doc it in volcano section, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35809: [SPARK-38513][K8S] Move custom scheduler-specific configs to under `spark.kubernetes.scheduler.NAME` prefix
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35809:
URL: https://github.com/apache/spark/pull/35809#issuecomment-1064612747
Thank you, @viirya and @Yikun .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #35809: [SPARK-38513][K8S] Move custom scheduler-specific configs to under `spark.kubernetes.scheduler.NAME` prefix
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #35809:
URL: https://github.com/apache/spark/pull/35809#discussion_r824249243
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/VolcanoFeatureStep.scala
##########
@@ -77,3 +70,8 @@ private[spark] class VolcanoFeatureStep extends KubernetesDriverCustomFeatureCon
SparkPod(k8sPod, pod.container)
}
}
+
+private[spark] object VolcanoFeatureStep {
+ val POD_GROUP_ANNOTATION = "scheduling.k8s.io/group-name"
+ val POD_GROUP_TEMPLATE_FILE_KEY = "spark.kubernetes.scheduler.volcano.podGroupTemplateFile"
Review comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35809: [SPARK-38513][K8S] Move custom scheduler-specific configs to under `spark.kubernetes.scheduler.NAME` prefix
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35809:
URL: https://github.com/apache/spark/pull/35809#discussion_r824241291
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/VolcanoFeatureStep.scala
##########
@@ -77,3 +70,8 @@ private[spark] class VolcanoFeatureStep extends KubernetesDriverCustomFeatureCon
SparkPod(k8sPod, pod.container)
}
}
+
+private[spark] object VolcanoFeatureStep {
+ val POD_GROUP_ANNOTATION = "scheduling.k8s.io/group-name"
+ val POD_GROUP_TEMPLATE_FILE_KEY = "spark.kubernetes.scheduler.volcano.podGroupTemplateFile"
Review comment:
Since this is only applicable for `volcano` scheduler and `VolcanoFeatureStep`, this should be here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #35809: [SPARK-38513][K8S] Move custom scheduler-specific configs to under `spark.kubernetes.scheduler.NAME` prefix
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #35809:
URL: https://github.com/apache/spark/pull/35809#issuecomment-1064578657
The merge script will add you as a co-author due to this commit, https://github.com/apache/spark/pull/35809/commits/a1943c9b18af3f68560d5a92f89449fd861f8fb4 , @Yikun .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35809: [SPARK-38513][K8S] Move custom scheduler-specific configs to under `spark.kubernetes.scheduler.NAME` prefix
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35809:
URL: https://github.com/apache/spark/pull/35809#issuecomment-1064578657
The merge script will add you as a co-author due to this commit, https://github.com/apache/spark/pull/35809/commits/a1943c9b18af3f68560d5a92f89449fd861f8fb4 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35809: [SPARK-38513][K8S] Move custom scheduler-specific configs to under `spark.kubernetes.scheduler.NAME` prefix
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35809:
URL: https://github.com/apache/spark/pull/35809#issuecomment-1064614569
All test passed. The currently running task is linter job's documentation generation which is irrelevant to this.
Merged to master for Apache Spark 3.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #35809: [SPARK-38513][K8S] Move custom scheduler-specific configs to under `spark.kubernetes.scheduler.NAME` prefix
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #35809:
URL: https://github.com/apache/spark/pull/35809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35809: [SPARK-38513][K8S] Move custom scheduler-specific configs to under `spark.kubernetes.scheduler.NAME` prefix
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35809:
URL: https://github.com/apache/spark/pull/35809#discussion_r824255693
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/VolcanoFeatureStep.scala
##########
@@ -77,3 +70,8 @@ private[spark] class VolcanoFeatureStep extends KubernetesDriverCustomFeatureCon
SparkPod(k8sPod, pod.container)
}
}
+
+private[spark] object VolcanoFeatureStep {
+ val POD_GROUP_ANNOTATION = "scheduling.k8s.io/group-name"
+ val POD_GROUP_TEMPLATE_FILE_KEY = "spark.kubernetes.scheduler.volcano.podGroupTemplateFile"
Review comment:
Yes, right~ Now, it's time to document here. Could you write some, @Yikun ?
- https://spark.apache.org/docs/latest/running-on-kubernetes.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org