You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Julian Hyde (Jira)" <ji...@apache.org> on 2022/06/27 20:28:00 UTC

[jira] [Commented] (CALCITE-4865) Allow table functions to be polymorphic

|  ![](cid:jira-generated-image-avatar-061eaef6-348c-499c-843d-4321cf40ff0b) |
[Julian
Hyde](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=julianhyde)
**commented** on [![Sub-task](cid:jira-generated-image-
avatar-336dae93-4383-49bf-b75f-80269f5629bd)
CALCITE-4865](https://issues.apache.org/jira/browse/CALCITE-4865)  
---|---  
|  
---  
|  [Re: Allow table functions to be
polymorphic](https://issues.apache.org/jira/browse/CALCITE-4865)  
---  
|

I reviewed again. You seem to use PTF throughout the doc. You can't do that;
the typical Calcite maintainer will not know what you mean. Write the doc
assuming limited knowledge, and define your terms or provide sufficient
references.

For example, row vs table semantics doesn't seem to me connected to the
"polymorphic" aspect of table functions, so I would just write "a table
function with row semantics..." rather than "a PTF with row semantics".

In one or two places javadoc needs markup to demarcate paragraphs and code
blocks.  
  
---  
|  |  [ ![Add Comment](cid:jira-generated-image-static-comment-
icon-35008b14-29d2-4ffc-bdc4-6e6faf3b848f)
](https://issues.apache.org/jira/browse/CALCITE-4865#add-comment "Add
Comment") |  [Add
Comment](https://issues.apache.org/jira/browse/CALCITE-4865#add-comment "Add
Comment")  
---|---  
  
|  This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9) |  |
![Atlassian logo](https://issues.apache.org/jira/images/mail/atlassian-email-
logo.png)  
---