You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/06 06:23:13 UTC

[GitHub] [kafka] Fleshgrinder commented on pull request #9374: MINOR: Fix NPE in KafkaAdminClient.describeUserScramCredentials

Fleshgrinder commented on pull request #9374:
URL: https://github.com/apache/kafka/pull/9374#issuecomment-704057098


   @chia7712 the server gets null right now, and the code you propose is more or less what I had originally. However, at least @rondagostino was directly confused by the ternary and precedence that's why we rewrote it to be easier to understand and easier to debug (now it's possible to set individual breakpoints). Modern languages like Kotlin and Rust have no ternary for a good reason. 😉 Imho it's better as is, despite being longer, especially because length doesn't translate directly to complex.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org