You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2018/10/08 15:05:53 UTC

[GitHub] spark pull request #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf fo...

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22545#discussion_r223397858
  
    --- Diff: python/pyspark/sql/session.py ---
    @@ -156,7 +156,7 @@ def getOrCreate(self):
                 default.
     
                 >>> s1 = SparkSession.builder.config("k1", "v1").getOrCreate()
    -            >>> s1.conf.get("k1") == s1.sparkContext.getConf().get("k1") == "v1"
    +            >>> s1.conf.get("k1") == "v1"
    --- End diff --
    
    @ueshin Could we also update the migration guide about this change?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org