[jira] [Updated] (HDFS-7496) Fix FsVolume removal race conditions on the DataNode

["Lei (Eddy) Xu (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDFS-7496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lei (Eddy) Xu updated HDFS-7496:
--------------------------------
    Attachment: HDFS-7496.002.patch

Thank you very much for these great comments, [~cmccabe]. 

I have changed {{FsVolumeList#getNext()}} to return {{FsVolumeReference}} so that who holds an non-closed {{FsVolumeReference}} can write this volume. It indeed makes the logic simplier. 

bq. {{FsDatasetAsyncDiskService#deleteAsync}}: we should not be passing in an FsVolumeSpi. We should be passing in an {{FsVolumeReference}}. Let the caller handle closing it.

It is an async call, should we let {{ReplicaFileDeleteTask}} close {{FsVolumeReference}}?




> Fix FsVolume removal race conditions on the DataNode 
> -----------------------------------------------------
>
>                 Key: HDFS-7496
>                 URL: https://issues.apache.org/jira/browse/HDFS-7496
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Colin Patrick McCabe
>            Assignee: Lei (Eddy) Xu
>         Attachments: HDFS-7496.000.patch, HDFS-7496.001.patch, HDFS-7496.002.patch
>
>
> We discussed a few FsVolume removal race conditions on the DataNode in HDFS-7489.  We should figure out a way to make removing an FsVolume safe.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)