You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by xi...@apache.org on 2023/12/08 00:48:12 UTC

(tinkerpop) branch 3.7-dev updated: Update nullability for AsString(), Conjoin() (#2360)

This is an automated email from the ASF dual-hosted git repository.

xiazcy pushed a commit to branch 3.7-dev
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git


The following commit(s) were added to refs/heads/3.7-dev by this push:
     new ec9e194add Update nullability for AsString(), Conjoin() (#2360)
ec9e194add is described below

commit ec9e194addb33bdd40395cabec4ec61a40d47203
Author: Florian Hockmann <fh...@florian-hockmann.de>
AuthorDate: Fri Dec 8 01:48:07 2023 +0100

    Update nullability for AsString(), Conjoin() (#2360)
    
    Handling of null values has been changed in #2351 for `asString()` and
    `conjoin()` to return `null` for `null` values instead of the string
    `"null"`.
---
 .../src/Gremlin.Net/Process/Traversal/GraphTraversal.cs      | 12 ++++++------
 gremlin-dotnet/src/Gremlin.Net/Process/Traversal/__.cs       |  6 +++---
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/gremlin-dotnet/src/Gremlin.Net/Process/Traversal/GraphTraversal.cs b/gremlin-dotnet/src/Gremlin.Net/Process/Traversal/GraphTraversal.cs
index ad44007f34..2c38967374 100644
--- a/gremlin-dotnet/src/Gremlin.Net/Process/Traversal/GraphTraversal.cs
+++ b/gremlin-dotnet/src/Gremlin.Net/Process/Traversal/GraphTraversal.cs
@@ -226,19 +226,19 @@ namespace Gremlin.Net.Process.Traversal
         /// <summary>
         ///     Adds the asString step to this <see cref="GraphTraversal{SType, EType}" />.
         /// </summary>
-        public GraphTraversal<TStart, string> AsString ()
+        public GraphTraversal<TStart, string?> AsString ()
         {
             Bytecode.AddStep("asString");
-            return Wrap<TStart, string>(this);
+            return Wrap<TStart, string?>(this);
         }
         
         /// <summary>
         ///     Adds the asString step to this <see cref="GraphTraversal{SType, EType}" />.
         /// </summary>
-        public GraphTraversal<TStart, TNewEnd> AsString<TNewEnd> (Scope scope)
+        public GraphTraversal<TStart, TNewEnd?> AsString<TNewEnd> (Scope scope)
         {
             Bytecode.AddStep("asString", scope);
-            return Wrap<TStart, TNewEnd>(this);
+            return Wrap<TStart, TNewEnd?>(this);
         }
 
         /// <summary>
@@ -591,10 +591,10 @@ namespace Gremlin.Net.Process.Traversal
         /// <summary>
         ///     Adds the conjoin step to this <see cref="GraphTraversal{SType, EType}" />.
         /// </summary>
-        public GraphTraversal<TStart, TEnd> Conjoin (string delimiter)
+        public GraphTraversal<TStart, TEnd?> Conjoin (string delimiter)
         {
             Bytecode.AddStep("conjoin", delimiter);
-            return Wrap<TStart, TEnd>(this);
+            return Wrap<TStart, TEnd?>(this);
         }
 
         /// <summary>
diff --git a/gremlin-dotnet/src/Gremlin.Net/Process/Traversal/__.cs b/gremlin-dotnet/src/Gremlin.Net/Process/Traversal/__.cs
index 0c28513a01..51bfe761f8 100644
--- a/gremlin-dotnet/src/Gremlin.Net/Process/Traversal/__.cs
+++ b/gremlin-dotnet/src/Gremlin.Net/Process/Traversal/__.cs
@@ -155,7 +155,7 @@ namespace Gremlin.Net.Process.Traversal
         /// <summary>
         ///     Spawns a <see cref="GraphTraversal{SType, EType}" /> and adds the asString step to that traversal.
         /// </summary>
-        public static GraphTraversal<object, string> AsString()
+        public static GraphTraversal<object, string?> AsString()
         {
             return new GraphTraversal<object, string>().AsString();            
         }
@@ -163,7 +163,7 @@ namespace Gremlin.Net.Process.Traversal
         /// <summary>
         ///     Spawns a <see cref="GraphTraversal{SType, EType}" /> and adds the asString step to that traversal.
         /// </summary>
-        public static GraphTraversal<object, E2> AsString<E2>(Scope scope)
+        public static GraphTraversal<object, E2?> AsString<E2>(Scope scope)
         {
             return new GraphTraversal<object, E2>().AsString<E2>(scope);            
         }
@@ -381,7 +381,7 @@ namespace Gremlin.Net.Process.Traversal
         /// <summary>
         ///     Spawns a <see cref="GraphTraversal{SType, EType}" /> and adds the conjoin step to that traversal.
         /// </summary>
-        public static GraphTraversal<object, object> Conjoin(string delimiter)
+        public static GraphTraversal<object, object?> Conjoin(string delimiter)
         {
             return new GraphTraversal<object, object>().Conjoin(delimiter);
         }