You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/29 01:08:48 UTC
[GitHub] [incubator-mxnet] connorgoggins commented on pull request #18188: update website version select drop down
connorgoggins commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-620934451
Thanks so much for your work on this, Yang! Nice addition of the caret to the dropdown menu! Also good job switching to the wider menu layout - the width looks much better than before.
A couple things: I personally don't like the fact that the user has to click on the menu to show the options. Not sure this is a good change to make if we're going for a smooth user experience. I think the version dropdown for install should work the same as the version dropdown menu for the general website: options displayed on hover.
I'm also not sure that using a scrollable window for the menu content is preferable when the full menu can be easily displayed on my screen, and the scroll window partially cuts off other options. Open to discuss this if folks have other opinions though.

Also, for me the caret isn't aligned properly:

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org