You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "bobbai00 (via GitHub)" <gi...@apache.org> on 2026/05/04 03:57:18 UTC
[PR] test(frontend): cover about-page login visibility branches [texera]
bobbai00 opened a new pull request, #4894:
URL: https://github.com/apache/texera/pull/4894
### What changes were proposed in this PR?
Adds 3 unit tests to `about.component.spec.ts` covering the `*ngIf` branches in `about.component.html` that codecov flagged on #4890:
- `<texera-local-login>` is hidden when the user is logged in.
- It is shown when the user is logged out and `config.env.localLogin` is true.
- It is hidden when the user is logged out but `config.env.localLogin` is false.
Provides `RouterTestingModule.withRoutes([])` plus a `NotificationService` spy via `useValue` so the real `LocalLoginComponent` renders under TestBed (matching the spy-mocked `NotificationService` pattern in `download.service.spec.ts` and `workflow-result-export.service.spec.ts`).
### Any related issues, documentation, discussions?
Sibling of #4890 (the actual `/about` layout fix). Split out of #4890 because the release branch still uses the old frontend testing framework, and the layout fix needs to backport cleanly without dragging the new spec along. This PR targets `main` only — no backport.
### How was this PR tested?
`yarn ng test --watch=false --include=\"src/app/hub/component/about/about.component.spec.ts\"` → 4 passed.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (claude-opus-4-7)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): cover about-page login visibility branches [texera]
Posted by "bobbai00 (via GitHub)" <gi...@apache.org>.
bobbai00 merged PR #4894:
URL: https://github.com/apache/texera/pull/4894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): cover about-page login visibility branches [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4894:
URL: https://github.com/apache/texera/pull/4894#issuecomment-4368142241
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/4894?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 43.29%. Comparing base ([`7cd34b1`](https://app.codecov.io/gh/apache/texera/commit/7cd34b17d1cb544e8b21f2ddde6b1cb0e43b107e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`100f267`](https://app.codecov.io/gh/apache/texera/commit/100f2677a191397094f8886839ec7419dac22aca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #4894 +/- ##
============================================
+ Coverage 43.12% 43.29% +0.16%
Complexity 2153 2153
============================================
Files 914 914
Lines 32196 32196
Branches 3253 3253
============================================
+ Hits 13886 13939 +53
+ Misses 17468 17414 -54
- Partials 842 843 +1
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/4894/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [frontend](https://app.codecov.io/gh/apache/texera/pull/4894/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `30.11% <ø> (+0.63%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/texera/pull/4894?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): cover about-page login visibility branches [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #4894:
URL: https://github.com/apache/texera/pull/4894#issuecomment-4368202093
hmm can you make CI happy first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org