You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Konstantin Kolinko <kn...@gmail.com> on 2009/12/23 08:50:26 UTC
Re: svn commit: r892800 - in /tomcat/jk/trunk: native/common/jk_status.c
xdocs/miscellaneous/changelog.xml
2009/12/21 <mt...@apache.org>:
> Author: mturk
> Date: Mon Dec 21 12:39:29 2009
> New Revision: 892800
>
> URL: http://svn.apache.org/viewvc?rev=892800&view=rev
> Log:
> Fix #48305. Skip if property ends with .secret
>
> Modified:
> tomcat/jk/trunk/native/common/jk_status.c
> tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
>
> + size_t nl = strlen(name);
> + if (nl > sizeof(".secret") &&
> + strcmp(name + nl - 7, ".secret") == 0) {
> + continue;
> + }
What is sizeof(".secret")? I suppose it is sizeof(char*) that is 4 or
8, and you are using an explicit '7' on the next line.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r892800 - in /tomcat/jk/trunk: native/common/jk_status.c
xdocs/miscellaneous/changelog.xml
Posted by Mladen Turk <mt...@apache.org>.
On 12/23/2009 08:50 AM, Konstantin Kolinko wrote:
> 2009/12/21<mt...@apache.org>:
>> Author: mturk
>> Date: Mon Dec 21 12:39:29 2009
>> New Revision: 892800
>>
>> URL: http://svn.apache.org/viewvc?rev=892800&view=rev
>> Log:
>> Fix #48305. Skip if property ends with .secret
>>
>> Modified:
>> tomcat/jk/trunk/native/common/jk_status.c
>> tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
>>
>> + size_t nl = strlen(name);
>> + if (nl> sizeof(".secret")&&
>> + strcmp(name + nl - 7, ".secret") == 0) {
>> + continue;
>> + }
>
> What is sizeof(".secret")? I suppose it is sizeof(char*) that is 4 or
> 8, and you are using an explicit '7' on the next line.
Right, should be 'sizeof(".secret") - 1'.
and sizeof("foo") is 4 -> strlen("foo") + 1 FYI :)
--
^TM
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org