You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/03/14 09:06:48 UTC
svn commit: r1887625 -
/pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/process/TrailerValidationProcess.java
Author: tilman
Date: Sun Mar 14 09:06:48 2021
New Revision: 1887625
URL: http://svn.apache.org/viewvc?rev=1887625&view=rev
Log:
PDFBOX-4892: simplify code + performance improvement, as suggested by valerybokov
Modified:
pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/process/TrailerValidationProcess.java
Modified: pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/process/TrailerValidationProcess.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/process/TrailerValidationProcess.java?rev=1887625&r1=1887624&r2=1887625&view=diff
==============================================================================
--- pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/process/TrailerValidationProcess.java (original)
+++ pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/process/TrailerValidationProcess.java Sun Mar 14 09:06:48 2021
@@ -173,21 +173,18 @@ public class TrailerValidationProcess ex
}
// ---- compare both arrays
boolean isEqual = true;
- for (COSBase of : ((COSArray) idFirst).toList())
+ for (COSBase of : (COSArray) idFirst)
{
boolean oneIsEquals = false;
- for (COSBase ol : ((COSArray) idLast).toList())
+ String ofString = ((COSString) of).getString();
+ for (COSBase ol : (COSArray) idLast)
{
- // ---- according to PDF Reference 1-4, ID is an array containing two
- // strings
- if (!oneIsEquals)
- {
- oneIsEquals = ((COSString) ol).getString().equals(((COSString) of).getString());
- }
- else
+ // ---- according to PDF Reference 1-4, ID is an array containing two strings
+ if (oneIsEquals)
{
break;
}
+ oneIsEquals = ((COSString) ol).getString().equals(ofString);
}
isEqual &= oneIsEquals;
if (!isEqual)