[jira] [Commented] (IO-173) FileUtils.listFiles() doesn't return directories

["Sebb (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IO-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215343#comment-13215343 ] 

Sebb commented on IO-173:
-------------------------

Cannot change the behaviour of an existing method (*) - that could break lots of applications.

(*) except to fix a bug, which this is not.
                
> FileUtils.listFiles() doesn't return directories
> ------------------------------------------------
>
>                 Key: IO-173
>                 URL: https://issues.apache.org/jira/browse/IO-173
>             Project: Commons IO
>          Issue Type: Improvement
>          Components: Utilities
>    Affects Versions: 1.4
>            Reporter: François Loison
>         Attachments: IO-173.patch
>
>
> FileUtils.listFiles() returns only files and not directories.
> So it can't be used to retrieve sub-directories.
> Some fix could be applied:
> {code}
>  private static void innerListFiles(Collection files, File directory,
>             IOFileFilter filter) {
>         File[] found = directory.listFiles((FileFilter) filter);
>         if (found != null) {
>             for (int i = 0; i < found.length; i++) {
>                 if (found[i].isDirectory()) {
> >>> fix
>                     if ( addDirectories ) {
>                        files.add(found[i]);
>                     }
> >>> end fix
>                     innerListFiles(files, found[i], filter);
>                 } else {
>                     files.add(found[i]);
>                 }
>             }
>         }
>     }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira