[GitHub] [inlong] TszKitLo40 commented on a diff in pull request #5288: [INLONG-5281][TubeMQ] Reconnect to tubemq server if StandbyException is thrown

[GitBox <gi...@apache.org>]

TszKitLo40 commented on code in PR #5288:
URL: https://github.com/apache/inlong/pull/5288#discussion_r933910120


##########
inlong-tubemq/tubemq-client-twins/tubemq-client-go/client/heartbeat.go:
##########
@@ -129,9 +129,9 @@ func (h *heartbeatManager) consumerHB2Master() {
 				return
 			}
 		}
+		h.consumer.masterHBRetry = 0

Review Comment:
   In https://github.com/apache/inlong/blob/master/inlong-tubemq/tubemq-client-twins/tubemq-client-cpp/src/baseconsumer.cc#L566
   `master_sh_retry_cnt_` in C++ SDK is the same meaning of `masterHBRetry` in Go SDK. But it seems that C++ SDK also does not try to reconnect to another address if `master_sh_retry_cnt_` exceeds the `config_.GetMaxHeartBeatRetryTimes`, it just enlarge the value. Or do I miss some logic of C++ SDK? @gosonzhang 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org